From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: Don't schedule tracepoints when exclude_kernel is set
Date: Sat, 9 Apr 2011 15:17:02 +0200 [thread overview]
Message-ID: <20110409131702.GA14331@elte.hu> (raw)
In-Reply-To: <1302354884.9086.1272.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Fri, 2011-04-08 at 22:57 +0200, Frederic Weisbecker wrote:
> > Instead of checking attr.exclude_kernel anytime a tracepoint
> > event triggers, simply don't schedule the tracepoint it that
> > attribute is set. This makes one test less in the tracing
> > path.
>
> Meh, I'd much rather someone spend some time on finishing the below,
> which is a much bigger improvement for trace-events.
>
> ---
> Subject: perf: Tracepoint collection support
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Sat Nov 20 18:09:34 CET 2010
>
> Due to popular demand this implements a tracepoint collection event
> { .type = PERF_TYPE_TRACEPOINT, .config = ~0ULL }. by default it
> contains no tracepoints, but tracepoints can be added using:
> ioctl(fd, PERF_EVENT_IOC_ADD_TP, tp_id);
+1 !!!
This is like a super-important feature.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-09 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 20:57 [PATCH] perf: Don't schedule tracepoints when exclude_kernel is set Frederic Weisbecker
2011-04-09 13:14 ` Peter Zijlstra
2011-04-09 13:17 ` Ingo Molnar [this message]
2011-04-09 13:27 ` Frederic Weisbecker
2011-04-09 13:37 ` Peter Zijlstra
2011-04-12 15:48 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110409131702.GA14331@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.