Re: [Qemu-devel] [PATCH 2/3] exec: Remove a type cast which is no longer needed

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Mar 26, 2011 at 09:06:56PM +0100, Stefan Weil wrote:
> All other type casts in calls of cpu_physical_memory_write are
> used by hardware emulations and will be fixed by separate patches.
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  exec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 964ce31..d7afe30 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -4249,7 +4249,7 @@ void stw_phys(target_phys_addr_t addr, uint32_t val)
>  void stq_phys(target_phys_addr_t addr, uint64_t val)
>  {
>      val = tswap64(val);
> -    cpu_physical_memory_write(addr, (const uint8_t *)&val, 8);
> +    cpu_physical_memory_write(addr, &val, 8);
>  }
>  
>  /* virtual memory access for debug (includes writing to ROM) */
> -- 
> 1.7.2.5
> 

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net