From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35669 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q91y1-0000Iz-PG
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 17:14:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q91y0-0003aF-NG
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 17:14:45 -0400
Received: from hall.aurel32.net ([88.191.126.93]:55648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q91y0-0003a4-Ei
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 17:14:44 -0400
Date: Sun, 10 Apr 2011 23:14:41 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110410211441.GO28617@hall.aurel32.net>
References: <1302462766-8560-1-git-send-email-aurelien@aurel32.net>
	<E7FFE5CB-E8F0-489F-835F-3D8F9FF2F890@suse.de>
	<BANLkTikmrCCAyXOQLPbahH001xaNhbkAWg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <BANLkTikmrCCAyXOQLPbahH001xaNhbkAWg@mail.gmail.com>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On Sun, Apr 10, 2011 at 09:08:55PM +0100, Peter Maydell wrote:
> On 10 April 2011 20:23, Alexander Graf <agraf@suse.de> wrote:
> > On 10.04.2011, at 21:12, Aurelien Jarno wrote:
> >> Now that PPC defaults to softfloat which always provides float128
> >> support, there is no need to keep two version of the code, depending if
> >> float128 support is available or not. Suggested by Peter Maydell.
> 
> > Looks good to me, but I'd leave this to Peter's ack.
> 
> I think it's a sensible (and pretty straightforward) cleanup, yes.
> [my bias towards emulation-accuracy means I don't really see
> much place for softfloat-native in a tcg qemu target, so I have
> no compunction about dropping support for it. :-)]

It seems that also what people want. We regularly got complain about
FP emulation precision (at least for the x86 target), but I don't
remember someone complaining about the speed of the FP emulation.

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 

Thanks for the review.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net