From: David Sterba <dave@jikos.cz>
To: Hugo Mills <hugo@carfax.org.uk>
Cc: chris.mason@oracle.com, dave@jikos.cz, lizf@cn.fujitsu.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v5 3/8] btrfs: Factor out enumeration of chunks to a separate function
Date: Mon, 11 Apr 2011 00:11:25 +0200 [thread overview]
Message-ID: <20110410221125.GF31675@twin.jikos.cz> (raw)
In-Reply-To: <1302469571-12605-4-git-send-email-hugo@carfax.org.uk>
On Sun, Apr 10, 2011 at 10:06:06PM +0100, Hugo Mills wrote:
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index cf019af..20c2772 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2029,6 +2029,97 @@ static u64 div_factor(u64 num, int factor)
> +static void balance_move_chunks(struct btrfs_root *chunk_root,
> + struct btrfs_balance_info *bal_info,
> + struct btrfs_path *path,
> + struct btrfs_key *key)
> +{
> + int ret;
> +
> + ret = btrfs_relocate_chunk(chunk_root,
> + chunk_root->root_key.objectid,
> + key->objectid,
> + key->offset);
> + BUG_ON(ret && ret != -ENOSPC);
> + spin_lock(&chunk_root->fs_info->balance_info_lock);
> + bal_info->completed++;
> + spin_unlock(&chunk_root->fs_info->balance_info_lock);
> + printk(KERN_INFO "btrfs: balance: %llu/%llu block groups completed\n",
> + bal_info->completed, bal_info->expected);
as you've changed 'completed' and 'expected' members to 32bit, change
%llu to %u.
d/
next prev parent reply other threads:[~2011-04-10 22:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 21:06 [PATCH v5 0/8] Balance mangement Hugo Mills
2011-04-10 21:06 ` [PATCH v5 1/8] btrfs: Balance progress monitoring Hugo Mills
2011-04-11 5:34 ` Helmut Hullen
2011-04-11 8:48 ` Hugo Mills
2011-04-12 17:12 ` David Sterba
2011-04-12 18:42 ` Hugo Mills
2011-04-13 13:34 ` David Sterba
2011-04-10 21:06 ` [PATCH v5 2/8] btrfs: Cancel filesystem balance Hugo Mills
2011-04-10 21:06 ` [PATCH v5 3/8] btrfs: Factor out enumeration of chunks to a separate function Hugo Mills
2011-04-10 22:11 ` David Sterba [this message]
2011-04-10 21:06 ` [PATCH v5 4/8] btrfs: Implement filtered balance ioctl Hugo Mills
2011-04-10 21:06 ` [PATCH v5 5/8] btrfs: Balance filter for device ID Hugo Mills
2011-04-10 21:06 ` [PATCH v5 6/8] btrfs: Balance filter for virtual address ranges Hugo Mills
2011-04-10 21:06 ` [PATCH v5 7/8] btrfs: Replication-type information Hugo Mills
2011-04-10 21:06 ` [PATCH v5 8/8] btrfs: Balance filter for physical device address Hugo Mills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110410221125.GF31675@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=chris.mason@oracle.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.