From: Wei Wang2 <wei.wang2@amd.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "Ostrovsky, Boris" <Boris.Ostrovsky@amd.com>,
"Huang2, Wei" <Wei.Huang2@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] AMD IOMMU: Fix an interrupt remapping issue (v2)
Date: Mon, 11 Apr 2011 09:39:34 +0200 [thread overview]
Message-ID: <201104110939.34840.wei.wang2@amd.com> (raw)
In-Reply-To: <4DA2C89A020000780003AD92@vpn.id2.novell.com>
On Monday 11 April 2011 09:23:38 Jan Beulich wrote:
> >>> On 08.04.11 at 18:52, Wei Wang2 <wei.wang2@amd.com> wrote:
> >
> > Jan, How dose this one look like to you?
>
> Much better, but still not quite there: The unmasking must happen
> *after* the writing of the upper half (if that's what is being modified).
>
> You could also skip the unmasking altogether if saved_mask == 1.
>
> And if you start using __io_apic_write() (which I find very desirable)
> is there a reason not to use it (and __io_apic_read()) in all of the
> other places you touch anyway, too?
>
> Jan
Good points. I will send a new version addressing the remaining issues.
Thanks,
Wei
next prev parent reply other threads:[~2011-04-11 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 11:35 [PATCH] AMD IOMMU: Fix an interrupt remapping issue Wei Wang2
2011-04-08 13:43 ` Jan Beulich
2011-04-08 14:26 ` Wei Wang2
2011-04-08 14:39 ` Jan Beulich
2011-04-08 15:06 ` Wei Wang2
2011-04-08 16:52 ` [PATCH] AMD IOMMU: Fix an interrupt remapping issue (v2) Wei Wang2
2011-04-11 7:23 ` Jan Beulich
2011-04-11 7:39 ` Wei Wang2 [this message]
2011-04-11 10:31 ` [PATCH V3] AMD IOMMU: Fix an interrupt remapping issue Wei Wang2
2011-04-11 11:35 ` Jan Beulich
2011-07-19 9:37 ` George Dunlap
2011-07-19 9:59 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104110939.34840.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=Boris.Ostrovsky@amd.com \
--cc=JBeulich@novell.com \
--cc=Wei.Huang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.