Re: [PATCH 0/2] input: rotary-encoder: add support for half-period encoders

[Johan Hovold <jhovold@gmail.com>]

On Fri, Apr 08, 2011 at 09:39:21AM +0200, Daniel Mack wrote:
> On Tue, Apr 5, 2011 at 8:15 PM, Johan Hovold <jhovold@gmail.com> wrote:
> > Hi,
> >
> > These patches add support for rotary-encoders which have two stable states per
> > input signal period.
> >
> > The first patch refactors state retrieval and event reporting and the second
> > adds support for such half-period encoders.
> 
> I have no objections to let the code in, and the patch looks sane to me.
> 
> However, I don't currently have access to the hardware I wrote the
> driver for, so I can't test right now, but will do at some later
> point.

It is possible to test non-half-period mode with a half-period encoder
(and vice verse) and I've verified that my patches do not change the
original state machine. In particular, every other event is still
missing as no event is delivered in the armed-state in non-half-period
mode.

> Feel free to add my Acked-by:, and I will get back to you in case I
> encounter any trouble.

Thanks,
Johan