Re: [PATCH v2] lowpan-tools_0.2.2; : fix build with static libnl1

[Stefan Schmidt <stefan@datenfreihafen.org>]

Hello.

On Mon, 2011-04-11 at 11:08, Anders Darander wrote:
> 
> 
> On 11 apr 2011, at 10:02, "Martin Jansa" <martin.jansa@gmail.com> wrote:
> 
> > On Sun, Apr 10, 2011 at 07:27:21PM +0200, Anders Darander wrote:
> >> * add NL_CFLAGS to a few Makefiles.am
> > 
> > look like adding -D_GNU_SOURCE not $(NL_CFLAGS) except iplink/Makefile.am 
> > and lib/Makefile.am, why was -D_GNU_SOURCE needed?
> 
> Hm, I should probably update that patch description to reflect that NL_CFLAGS is only added on a couple of places, while _GNU_SOURCE is added on a few more places.
> 
> -D_GNU_SOURCE was added as otherwise a struct, ucred if I remember correctly, was undefined. (I don't currently have access to that computer.)
> 
> > and lowpan-tools_0.2.2.bb gets PR bump from INC_PR, no need to bump .1
> > too.
> 
> Ok, I bumped PR in lowpan-tools_0.2.2.bb as I modified that file also...
> 
> > but otherwise looks ok (I haven't tested it - never used lowpan-tools).
> > 
> 
> I'll try to make a somewhat better explanation in the included patch during the evening, and I can also remove the PR bump before submitting a third revision of the patch. Hopefully I can find some time this evening.

Thanks for this. I will test your patch and push it out after this.

While I still want to get lowpan-tools fixed for libnl2 I think this
is a good solution for the current releases.

regards
Stefan Schmidt