Re: [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time

From: Lu Guanqun <guanqun.lu@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: tlv320dac33: Lower the OSC calibration time
Date: Mon, 11 Apr 2011 21:05:32 +0800	[thread overview]
Message-ID: <20110411130532.GC11072@qtel.sh.intel.com> (raw)
In-Reply-To: <1302526664-1497-1-git-send-email-peter.ujfalusi@nokia.com>

On Mon, Apr 11, 2011 at 08:57:44PM +0800, Peter Ujfalusi wrote:
> To get correct calibration, we can decrease the time
> needed for the OSC to calibrate itself.
> With this change we can safe ~15ms in the OSC

s/safe/save/

> calibration phase.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
>  sound/soc/codecs/tlv320dac33.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
> index c109f6d..401a7ce 100644
> --- a/sound/soc/codecs/tlv320dac33.c
> +++ b/sound/soc/codecs/tlv320dac33.c
> @@ -946,8 +946,8 @@ static int dac33_prepare_chip(struct snd_pcm_substream *substream)
>  	/* Write registers 0x08 and 0x09 (MSB, LSB) */
>  	dac33_write16(codec, DAC33_INT_OSC_FREQ_RAT_A, oscset);
>  
> -	/* calib time: 128 is a nice number ;) */
> -	dac33_write(codec, DAC33_CALIB_TIME, 128);
> +	/* OSC calibration time */
> +	dac33_write(codec, DAC33_CALIB_TIME, 96);
>  
>  	/* adjustment treshold & step */
>  	dac33_write(codec, DAC33_INT_OSC_CTRL_B, DAC33_ADJTHRSHLD(2) |
> -- 
> 1.7.4.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
guanqun