From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/amd-iommu: Add support for invalidate_all command
Date: Mon, 11 Apr 2011 16:08:21 +0200 [thread overview]
Message-ID: <20110411140821.GJ23633@amd.com> (raw)
In-Reply-To: <20110411135708.GB28056@khazad-dum.debian.net>
On Mon, Apr 11, 2011 at 09:57:08AM -0400, Henrique de Moraes Holschuh wrote:
> On Mon, 11 Apr 2011, Joerg Roedel wrote:
> > This patch adds support for the invalidate_all command
> > present in new versions of the AMD IOMMU.
>
> ...
>
> > #define CMD_COMPL_WAIT 0x01
> > #define CMD_INV_DEV_ENTRY 0x02
> > #define CMD_INV_IOMMU_PAGES 0x03
> > +#define CMD_INV_ALL 0x08
>
> ...
>
> > @@ -463,6 +463,12 @@ static void build_inv_iommu_pages(struct iommu_cmd *cmd, u64 address,
> > cmd->data[2] |= CMD_INV_IOMMU_PAGES_PDE_MASK;
> > }
> >
> > +static void build_inv_all(struct iommu_cmd *cmd)
> > +{
> > + memset(cmd, 0, sizeof(*cmd));
> > + CMD_SET_TYPE(cmd, CMD_INV_DEV_ENTRY);
>
> Huh?
Copy&Paste error :( Thanks for pointing it out.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-04-11 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 9:32 [PATCH 0/2] AMD IOMMU Extended feature base support Joerg Roedel
2011-04-11 9:32 ` [PATCH 1/2] x86/amd-iommu: Add extended feature detection Joerg Roedel
2011-04-11 15:11 ` Rolf Eike Beer
2011-04-12 6:33 ` Roedel, Joerg
2011-04-11 9:32 ` [PATCH 2/2] x86/amd-iommu: Add support for invalidate_all command Joerg Roedel
2011-04-11 13:57 ` Henrique de Moraes Holschuh
2011-04-11 14:08 ` Roedel, Joerg [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-12 7:44 [PATCH 0/2] AMD IOMMU Extended feature base support v2 Joerg Roedel
2011-04-12 7:44 ` [PATCH 2/2] x86/amd-iommu: Add support for invalidate_all command Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411140821.GJ23633@amd.com \
--to=joerg.roedel@amd.com \
--cc=hmh@hmh.eng.br \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.