From: Stephen Hemminger <shemminger@vyatta.com>
To: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, anirban.chakraborty@qlogic.com
Subject: Re: [PATCHv2 NEXT 2/8] qlcnic: fix eswitch stats
Date: Mon, 11 Apr 2011 16:09:46 -0700 [thread overview]
Message-ID: <20110411160946.7a2ec69a@nehalam> (raw)
In-Reply-To: <1286205297-23214-2-git-send-email-amit.salecha@qlogic.com>
On Mon, 4 Oct 2010 08:14:51 -0700
Amit Kumar Salecha <amit.salecha@qlogic.com> wrote:
> +
> +#define QLCNIC_ADD_ESW_STATS(VAL1, VAL2)\
> +do { \
> + if (((VAL1) == QLCNIC_ESW_STATS_NOT_AVAIL) && \
> + ((VAL2) != QLCNIC_ESW_STATS_NOT_AVAIL)) \
> + (VAL1) = (VAL2); \
> + else if (((VAL1) != QLCNIC_ESW_STATS_NOT_AVAIL) && \
> + ((VAL2) != QLCNIC_ESW_STATS_NOT_AVAIL)) \
> + (VAL1) += (VAL2); \
> +} while (0)
Fugly macro. Make it an inline function?
next prev parent reply other threads:[~2011-04-11 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1286205297-23214-1-git-send-email-amit.salecha@qlogic.com>
2010-10-04 15:14 ` [PATCHv2 NEXT 2/8] qlcnic: fix eswitch stats Amit Kumar Salecha
2011-04-11 22:55 ` David Miller
2011-04-12 4:48 ` Amit Salecha
2011-04-11 23:09 ` Stephen Hemminger [this message]
2010-10-04 15:14 ` [PATCHv2 NEXT 3/8] qlcnic: fix diag register Amit Kumar Salecha
2010-10-04 15:14 ` [PATCHv2 NEXT 4/8] qlcnic: fix endianess for lro Amit Kumar Salecha
2010-10-04 15:14 ` [PATCHv2 NEXT 5/8] qlcnic: fix vlan TSO on big endian machine Amit Kumar Salecha
2010-10-04 15:14 ` [PATCHv2 NEXT 6/8] qlcnic: sparse warning fixes Amit Kumar Salecha
2011-04-11 23:00 ` Ben Hutchings
2010-10-04 15:14 ` [PATCHv2 NEXT 7/8] qlcnic: cleanup port mode setting Amit Kumar Salecha
2010-10-04 15:14 ` [PATCHv2 NEXT 8/8] qlcnic: set mtu lower limit Amit Kumar Salecha
2010-10-04 14:20 [PATCHv2 NEXT 0/8]qlcnic: miscellaneous fixes Amit Kumar Salecha
2010-10-04 14:20 ` [PATCHv2 NEXT 2/8] qlcnic: fix eswitch stats Amit Kumar Salecha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411160946.7a2ec69a@nehalam \
--to=shemminger@vyatta.com \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.