From: Stephen Hemminger <shemminger@vyatta.com>
To: Bruce Allan <bruce.w.allan@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 RFC PATCH] ethtool: allow custom interval for physical identification
Date: Mon, 11 Apr 2011 16:26:01 -0700 [thread overview]
Message-ID: <20110411162601.6686f169@nehalam> (raw)
In-Reply-To: <20110411231635.9339.36369.stgit@gitlad.jf.intel.com>
On Mon, 11 Apr 2011 16:16:35 -0700
Bruce Allan <bruce.w.allan@intel.com> wrote:
> When physical identification of an adapter is done by toggling the
> mechanism on and off through software utilizing the .set_phys_id operation,
> it is done with a fixed duration for both on and off states. Some drivers
> may want to set a custom duration for the on/off intervals. This patch
> changes the API so the return code from the driver's entry point can
> specify the interval duration as a positive number; -EINVAL is still
> allowed in order to use the default single on/off interval per second.
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
IMHO this is -EOVERKILL.
--
next prev parent reply other threads:[~2011-04-11 23:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 23:16 [net-next-2.6 RFC PATCH] ethtool: allow custom interval for physical identification Bruce Allan
2011-04-11 23:26 ` Stephen Hemminger [this message]
2011-04-11 23:30 ` Allan, Bruce W
2011-04-12 0:00 ` Ben Hutchings
2011-04-12 1:07 ` Allan, Bruce W
2011-04-12 16:28 ` Ben Hutchings
2011-04-12 18:17 ` Allan, Bruce W
2011-04-12 18:23 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411162601.6686f169@nehalam \
--to=shemminger@vyatta.com \
--cc=bruce.w.allan@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.