From: "François Romieu" <romieu@fr.zoreil.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, David Dillow <dave@thedillows.org>,
Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH v2] net: r8169: convert to hw_features
Date: Mon, 11 Apr 2011 20:47:39 +0200 [thread overview]
Message-ID: <20110411184739.GA17331@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20110411133029.GA12119@rere.qmqm.pl>
On Mon, Apr 11, 2011 at 03:30:29PM +0200, Michał Mirosław wrote:
> On Sun, Apr 10, 2011 at 05:45:08PM +0200, François Romieu wrote:
[...]
> > The description should include :
> > - Rx VLAN tag stripping is now enabled by default
>
> Actually, it was enabled by default before. NETIF_F_HW_VLAN_TX_RX was
> #defined to be NETIF_F_HW_VLAN_TX+NETIF_F_HW_VLAN_RX.
It was enabled in dev->features but it was necessary to configure at
least one VLAN before the hardware CPlusCmd register was instructed
to strip Rx vlan tag (let aside 8110SCd or tagged Tx packets which
where sent as such).
I am not sure it will be noticed.
[...]
> Yes. hw_features signifies what can be toggled by user, but does not
> imply state of features not present there.
Thanks for the clarification.
On a different topic, David was right. The large send feature needs
more fixing. I should have a first tested patch for wednesday.
Hayes, I have a 8168c manual at hand. Do all 8168 have the same Tx
descriptors layout ?
--
Ueimor
next prev parent reply other threads:[~2011-04-11 18:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 12:38 [PATCH] net: r8169: convert to hw_features Michał Mirosław
2011-04-08 12:44 ` Michał Mirosław
2011-04-08 15:37 ` David Dillow
2011-04-08 16:35 ` [PATCH v2] " Michał Mirosław
2011-04-11 1:55 ` David Miller
[not found] ` <20110410154508.GA17091@electric-eye.fr.zoreil.com>
2011-04-11 13:30 ` Michał Mirosław
2011-04-11 18:47 ` François Romieu [this message]
2011-04-11 19:15 ` Michał Mirosław
2011-04-11 19:30 ` François Romieu
2011-04-12 2:10 ` hayeswang
2011-04-13 17:47 ` François Romieu
[not found] ` <1302718764.3167.7.camel@lap75545.ornl.gov>
2011-04-18 18:08 ` Francois Romieu
2011-04-19 3:24 ` David Dillow
2011-04-19 5:54 ` David Miller
2011-04-20 19:13 ` Francois Romieu
2011-04-20 19:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411184739.GA17331@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=dave@thedillows.org \
--cc=hayeswang@realtek.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.