All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dave Airlie <airlied@gmail.com>,
	Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY
Date: Mon, 11 Apr 2011 14:58:36 -0400	[thread overview]
Message-ID: <20110411185807.GC2511@tuxdriver.com> (raw)
In-Reply-To: <1302547162.5663.2.camel@wwguy-ubuntu>

On Mon, Apr 11, 2011 at 11:39:22AM -0700, wwguy wrote:
> On Mon, 2011-04-11 at 10:06 -0700, John W. Linville wrote:
> > Otherwise, IWLWIFI_LEGACY has to be selected independently before the
> > drivers are made available.
> > 
> > Reported-by: Dave Airlie <airlied@gmail.com>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > Cc: Stanislaw Gruszka <sgruszka@redhat.com>
> > Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > ---
> >  drivers/net/wireless/iwlegacy/Kconfig |    9 +++++----
> >  1 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/iwlegacy/Kconfig b/drivers/net/wireless/iwlegacy/Kconfig
> > index 2a45dd4..aef65cd 100644
> > --- a/drivers/net/wireless/iwlegacy/Kconfig
> > +++ b/drivers/net/wireless/iwlegacy/Kconfig
> > @@ -1,6 +1,5 @@
> >  config IWLWIFI_LEGACY
> > -	tristate "Intel Wireless Wifi legacy devices"
> > -	depends on PCI && MAC80211
> > +	tristate
> >  	select FW_LOADER
> >  	select NEW_LEDS
> >  	select LEDS_CLASS
> 
> Should we add some ---help--- here?, or not..

Why would you need it?  This is now automatically selected by the
driver -- the user doesn't see it.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

      reply	other threads:[~2011-04-11 19:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-09  7:39 iwlegacy Kconfig mess Dave Airlie
2011-04-11 17:06 ` [PATCH] iwlegacy: make iwl3945 and iwl4965 select IWLWIFI_LEGACY John W. Linville
2011-04-11 18:39   ` wwguy
2011-04-11 18:58     ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110411185807.GC2511@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=airlied@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.