diff for duplicates of <20110411215619.GA27943@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 76e598b..cc69bc2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ -On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafał Miłecki wrote: +On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote: > 2011/4/11 Greg KH <greg@kroah.com>: -> > On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafał Miłecki wrote: +> > On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafa? Mi?ecki wrote: > >> 2011/4/11 Greg KH <greg@kroah.com>: -> >> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafał Miłecki wrote: +> >> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafa? Mi?ecki wrote: > >> >> +static void axi_release_core_dev(struct device *dev) > >> >> +{ -> >> >> + /* Silent lack-of-release warning */ +> >> >> + ? ? /* Silent lack-of-release warning */ > >> >> +} > >> > > >> > Ok, WTF!!!! @@ -20,12 +20,12 @@ On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafał Miłecki wrote: Ok, you forgot the ':)' then... -> > Please read the documentation for how to do this properly. I find it +> > Please read the documentation for how to do this properly. ?I find it > > really hard to believe that you wrote that comment instead of putting in > > the 2 lines of code required for this function. > > > > Especially as-it-is, your code does not work properly and leaks memory -> > badly. Why would you do that on purpose? +> > badly. ?Why would you do that on purpose? > > I tried to read some documentation about this. > @@ -45,7 +45,7 @@ in the release function. > 2) LDD3 says: > > The method is called when the last reference to the device is removed; it is called -> > from the embedded kobject’s release method. All device structures registered with +> > from the embedded kobject?s release method. All device structures registered with > > the core must have a release method, or the kernel prints out scary complaints. > Well, I do not register any structs for AXI core. diff --git a/a/content_digest b/N1/content_digest index bbc7b0c..1fd0afd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,32 +3,20 @@ "ref\0BANLkTim155YxMUVJ=pmVs-rNhkovGPG6OQ@mail.gmail.com\0" "ref\020110411212513.GA17809@kroah.com\0" "ref\0BANLkTingqXAWTeOhcL6ER0UJfEdQF5Bo2A@mail.gmail.com\0" - "From\0Greg KH <greg@kroah.com>\0" - "Subject\0Re: [RFC][PATCH V3] axi: add AXI bus driver\0" + "From\0greg@kroah.com (Greg KH)\0" + "Subject\0[RFC][PATCH V3] axi: add AXI bus driver\0" "Date\0Mon, 11 Apr 2011 14:56:19 -0700\0" - "To\0Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>\0" - "Cc\0linux-wireless@vger.kernel.org" - John W. Linville <linville@tuxdriver.com> - George Kashperko <george@znau.edu.ua> - Arnd Bergmann <arnd@arndb.de> - Russell King <rmk@arm.linux.org.uk> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - b43-dev@lists.infradead.org - " Michael B\303\274sch <mb@bu3sch.de>" - linuxdriverproject <devel@linuxdriverproject.org> - Andy Botting <andy@andybotting.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Larry Finger <Larry.Finger@lwfinger.net>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote:\n" "> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> > On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "> > On Mon, Apr 11, 2011 at 11:19:13PM +0200, Rafa? Mi?ecki wrote:\n" "> >> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> >> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "> >> > On Mon, Apr 11, 2011 at 11:25:14PM +0200, Rafa? Mi?ecki wrote:\n" "> >> >> +static void axi_release_core_dev(struct device *dev)\n" "> >> >> +{\n" - "> >> >> + \302\240 \302\240 /* Silent lack-of-release warning */\n" + "> >> >> + ? ? /* Silent lack-of-release warning */\n" "> >> >> +}\n" "> >> >\n" "> >> > Ok, WTF!!!!\n" @@ -43,12 +31,12 @@ "\n" "Ok, you forgot the ':)' then...\n" "\n" - "> > Please read the documentation for how to do this properly. \302\240I find it\n" + "> > Please read the documentation for how to do this properly. ?I find it\n" "> > really hard to believe that you wrote that comment instead of putting in\n" "> > the 2 lines of code required for this function.\n" "> >\n" "> > Especially as-it-is, your code does not work properly and leaks memory\n" - "> > badly. \302\240Why would you do that on purpose?\n" + "> > badly. ?Why would you do that on purpose?\n" "> \n" "> I tried to read some documentation about this.\n" "> \n" @@ -68,7 +56,7 @@ "\n" "> 2) LDD3 says:\n" "> > The method is called when the last reference to the device is removed; it is called\n" - "> > from the embedded kobject\342\200\231s release method. All device structures registered with\n" + "> > from the embedded kobject?s release method. All device structures registered with\n" "> > the core must have a release method, or the kernel prints out scary complaints.\n" "> Well, I do not register any structs for AXI core.\n" "\n" @@ -102,4 +90,4 @@ "\n" greg k-h -a628e169b95633890cec59084a5f4a446b2b447319dfa05db39789643c4ef94d +270ccc7737814a4bb0a43d5f003d675d7042ec53d8ff6b3305cd9aa6cdd36560
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.