diff for duplicates of <20110411223632.GB31833@kroah.com> diff --git a/a/1.txt b/N1/1.txt index f9fb548..2ed740e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ -On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafał Miłecki wrote: +On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa? Mi?ecki wrote: > 2011/4/11 Greg KH <greg@kroah.com>: -> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafał Miłecki wrote: +> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote: > >> 2011/4/11 Greg KH <greg@kroah.com>: -> >> > Please read the documentation for how to do this properly. I find it +> >> > Please read the documentation for how to do this properly. ?I find it > >> > really hard to believe that you wrote that comment instead of putting in > >> > the 2 lines of code required for this function. > >> > > >> > Especially as-it-is, your code does not work properly and leaks memory -> >> > badly. Why would you do that on purpose? +> >> > badly. ?Why would you do that on purpose? > >> > >> I tried to read some documentation about this. > >> @@ -18,11 +18,11 @@ On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafał Miłecki wrote: > >> I *really* do not know how my driver should "free" core on AXI bus. > > > > The structure that you have created, added to the bus, is now ready to -> > have its memory freed. So free it. +> > have its memory freed. ?So free it. > > > > This usually means something like: -> > struct my_obj = to_my_obj(dev); -> > kfree(my_obj); +> > ? ? ? ?struct my_obj = to_my_obj(dev); +> > ? ? ? ?kfree(my_obj); > > in the release function. > > I register core->dev to the bus (I set core->dev.bus and @@ -38,7 +38,7 @@ problems. > >> 2) LDD3 says: > >> > The method is called when the last reference to the device is removed; it is called -> >> > from the embedded kobject’s release method. All device structures registered with +> >> > from the embedded kobject?s release method. All device structures registered with > >> > the core must have a release method, or the kernel prints out scary complaints. > >> Well, I do not register any structs for AXI core. > > @@ -52,7 +52,7 @@ problems. > >> allocated when registering drivers. *I do not* allocate such a struct, > >> so I believe I do exactly the same memory leak as SSB does. > > -> > Well someone allocated it, right? Who did it? If it wasn't you, where +> > Well someone allocated it, right? ?Who did it? ?If it wasn't you, where > > did that structure come from and why are you registering it on your bus? > > > >> Can you spend 2 more minues in addition to commenting my ideas and diff --git a/a/content_digest b/N1/content_digest index 6d2f4f6..2b512a2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,34 +5,22 @@ "ref\0BANLkTingqXAWTeOhcL6ER0UJfEdQF5Bo2A@mail.gmail.com\0" "ref\020110411215619.GA27943@kroah.com\0" "ref\0BANLkTimjThXn347+=m98NsBXY84guJjNqA@mail.gmail.com\0" - "From\0Greg KH <greg@kroah.com>\0" - "Subject\0Re: [RFC][PATCH V3] axi: add AXI bus driver\0" + "From\0greg@kroah.com (Greg KH)\0" + "Subject\0[RFC][PATCH V3] axi: add AXI bus driver\0" "Date\0Mon, 11 Apr 2011 15:36:32 -0700\0" - "To\0Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>\0" - "Cc\0linux-wireless@vger.kernel.org" - John W. Linville <linville@tuxdriver.com> - George Kashperko <george@znau.edu.ua> - Arnd Bergmann <arnd@arndb.de> - Russell King <rmk@arm.linux.org.uk> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - b43-dev@lists.infradead.org - " Michael B\303\274sch <mb@bu3sch.de>" - linuxdriverproject <devel@linuxdriverproject.org> - Andy Botting <andy@andybotting.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Larry Finger <Larry.Finger@lwfinger.net>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa? Mi?ecki wrote:\n" "> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote:\n" "> >> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> >> > Please read the documentation for how to do this properly. \302\240I find it\n" + "> >> > Please read the documentation for how to do this properly. ?I find it\n" "> >> > really hard to believe that you wrote that comment instead of putting in\n" "> >> > the 2 lines of code required for this function.\n" "> >> >\n" "> >> > Especially as-it-is, your code does not work properly and leaks memory\n" - "> >> > badly. \302\240Why would you do that on purpose?\n" + "> >> > badly. ?Why would you do that on purpose?\n" "> >>\n" "> >> I tried to read some documentation about this.\n" "> >>\n" @@ -43,11 +31,11 @@ "> >> I *really* do not know how my driver should \"free\" core on AXI bus.\n" "> >\n" "> > The structure that you have created, added to the bus, is now ready to\n" - "> > have its memory freed. \302\240So free it.\n" + "> > have its memory freed. ?So free it.\n" "> >\n" "> > This usually means something like:\n" - "> > \302\240 \302\240 \302\240 \302\240struct my_obj = to_my_obj(dev);\n" - "> > \302\240 \302\240 \302\240 \302\240kfree(my_obj);\n" + "> > ? ? ? ?struct my_obj = to_my_obj(dev);\n" + "> > ? ? ? ?kfree(my_obj);\n" "> > in the release function.\n" "> \n" "> I register core->dev to the bus (I set core->dev.bus and\n" @@ -63,7 +51,7 @@ "\n" "> >> 2) LDD3 says:\n" "> >> > The method is called when the last reference to the device is removed; it is called\n" - "> >> > from the embedded kobject\342\200\231s release method. All device structures registered with\n" + "> >> > from the embedded kobject?s release method. All device structures registered with\n" "> >> > the core must have a release method, or the kernel prints out scary complaints.\n" "> >> Well, I do not register any structs for AXI core.\n" "> >\n" @@ -77,7 +65,7 @@ "> >> allocated when registering drivers. *I do not* allocate such a struct,\n" "> >> so I believe I do exactly the same memory leak as SSB does.\n" "> >\n" - "> > Well someone allocated it, right? \302\240Who did it? \302\240If it wasn't you, where\n" + "> > Well someone allocated it, right? ?Who did it? ?If it wasn't you, where\n" "> > did that structure come from and why are you registering it on your bus?\n" "> >\n" "> >> Can you spend 2 more minues in addition to commenting my ideas and\n" @@ -95,4 +83,4 @@ "\n" greg k-h -4f8f31058a1187df94c098b9aab9beb7740beed346fbbf3c29084da3bb7811b7 +f32894b8e65531509ef8d430d9e0d36778654727326d2dcc3d44c34e013babc1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.