diff for duplicates of <20110411233506.GA13240@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 9140161..b2a31d0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,15 @@ -On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafał Miłecki wrote: +On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa? Mi?ecki wrote: > 2011/4/12 Greg KH <greg@kroah.com>: -> > On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafał Miłecki wrote: +> > On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa? Mi?ecki wrote: > >> 2011/4/11 Greg KH <greg@kroah.com>: -> >> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafał Miłecki wrote: +> >> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote: > >> >> 2011/4/11 Greg KH <greg@kroah.com>: -> >> >> > Please read the documentation for how to do this properly. I find it +> >> >> > Please read the documentation for how to do this properly. ?I find it > >> >> > really hard to believe that you wrote that comment instead of putting in > >> >> > the 2 lines of code required for this function. > >> >> > > >> >> > Especially as-it-is, your code does not work properly and leaks memory -> >> >> > badly. Why would you do that on purpose? +> >> >> > badly. ?Why would you do that on purpose? > >> >> > >> >> I tried to read some documentation about this. > >> >> @@ -20,11 +20,11 @@ On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafał Miłecki wrote: > >> >> I *really* do not know how my driver should "free" core on AXI bus. > >> > > >> > The structure that you have created, added to the bus, is now ready to -> >> > have its memory freed. So free it. +> >> > have its memory freed. ?So free it. > >> > > >> > This usually means something like: -> >> > struct my_obj = to_my_obj(dev); -> >> > kfree(my_obj); +> >> > ? ? ? ?struct my_obj = to_my_obj(dev); +> >> > ? ? ? ?kfree(my_obj); > >> > in the release function. > >> > >> I register core->dev to the bus (I set core->dev.bus and @@ -34,8 +34,8 @@ On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafał Miłecki wrote: > > > > That is exactly as it should be. > > -> > Then in your release function, free the struct axi_device. It's that -> > simple. To try to free it before then would be wrong and cause +> > Then in your release function, free the struct axi_device. ?It's that +> > simple. ?To try to free it before then would be wrong and cause > > problems. > > This is because it is defined as: diff --git a/a/content_digest b/N1/content_digest index 26ac879..57edfd9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,36 +7,24 @@ "ref\0BANLkTimjThXn347+=m98NsBXY84guJjNqA@mail.gmail.com\0" "ref\020110411223632.GB31833@kroah.com\0" "ref\0BANLkTinpKKRCrBik6-9C5WqcSDGuEt5yCw@mail.gmail.com\0" - "From\0Greg KH <greg@kroah.com>\0" - "Subject\0Re: [RFC][PATCH V3] axi: add AXI bus driver\0" + "From\0greg@kroah.com (Greg KH)\0" + "Subject\0[RFC][PATCH V3] axi: add AXI bus driver\0" "Date\0Mon, 11 Apr 2011 16:35:06 -0700\0" - "To\0Rafa\305\202 Mi\305\202ecki <zajec5@gmail.com>\0" - "Cc\0linux-wireless@vger.kernel.org" - John W. Linville <linville@tuxdriver.com> - George Kashperko <george@znau.edu.ua> - Arnd Bergmann <arnd@arndb.de> - Russell King <rmk@arm.linux.org.uk> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - b43-dev@lists.infradead.org - " Michael B\303\274sch <mb@bu3sch.de>" - linuxdriverproject <devel@linuxdriverproject.org> - Andy Botting <andy@andybotting.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Larry Finger <Larry.Finger@lwfinger.net>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "On Tue, Apr 12, 2011 at 12:45:33AM +0200, Rafa? Mi?ecki wrote:\n" "> 2011/4/12 Greg KH <greg@kroah.com>:\n" - "> > On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "> > On Tue, Apr 12, 2011 at 12:12:47AM +0200, Rafa? Mi?ecki wrote:\n" "> >> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> >> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa\305\202 Mi\305\202ecki wrote:\n" + "> >> > On Mon, Apr 11, 2011 at 11:36:39PM +0200, Rafa? Mi?ecki wrote:\n" "> >> >> 2011/4/11 Greg KH <greg@kroah.com>:\n" - "> >> >> > Please read the documentation for how to do this properly. \302\240I find it\n" + "> >> >> > Please read the documentation for how to do this properly. ?I find it\n" "> >> >> > really hard to believe that you wrote that comment instead of putting in\n" "> >> >> > the 2 lines of code required for this function.\n" "> >> >> >\n" "> >> >> > Especially as-it-is, your code does not work properly and leaks memory\n" - "> >> >> > badly. \302\240Why would you do that on purpose?\n" + "> >> >> > badly. ?Why would you do that on purpose?\n" "> >> >>\n" "> >> >> I tried to read some documentation about this.\n" "> >> >>\n" @@ -47,11 +35,11 @@ "> >> >> I *really* do not know how my driver should \"free\" core on AXI bus.\n" "> >> >\n" "> >> > The structure that you have created, added to the bus, is now ready to\n" - "> >> > have its memory freed. \302\240So free it.\n" + "> >> > have its memory freed. ?So free it.\n" "> >> >\n" "> >> > This usually means something like:\n" - "> >> > \302\240 \302\240 \302\240 \302\240struct my_obj = to_my_obj(dev);\n" - "> >> > \302\240 \302\240 \302\240 \302\240kfree(my_obj);\n" + "> >> > ? ? ? ?struct my_obj = to_my_obj(dev);\n" + "> >> > ? ? ? ?kfree(my_obj);\n" "> >> > in the release function.\n" "> >>\n" "> >> I register core->dev to the bus (I set core->dev.bus and\n" @@ -61,8 +49,8 @@ "> >\n" "> > That is exactly as it should be.\n" "> >\n" - "> > Then in your release function, free the struct axi_device. \302\240It's that\n" - "> > simple. \302\240To try to free it before then would be wrong and cause\n" + "> > Then in your release function, free the struct axi_device. ?It's that\n" + "> > simple. ?To try to free it before then would be wrong and cause\n" "> > problems.\n" "> \n" "> This is because it is defined as:\n" @@ -82,4 +70,4 @@ "\n" greg k-h -415b2466c5452ea211b97eb9f0390ce181b8a8d72082bd5e12a27fe2fa8ebf90 +a426bd95807125235e3f0f5e6a911bf22f29dfc274a7fde96e3bb6f1a62af699
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.