From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c Date: Tue, 12 Apr 2011 09:39:29 +0200 Message-ID: <20110412073929.GA26892@elte.hu> References: <20110401075011.GD7594@elte.hu> <1301672686-10096-1-git-send-email-florian@mickler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:52035 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434Ab1DLHjj (ORCPT ); Tue, 12 Apr 2011 03:39:39 -0400 Content-Disposition: inline In-Reply-To: <1301672686-10096-1-git-send-email-florian@mickler.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Florian Mickler Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , "Eric W. Biederman" , kurup_avinash@yahoo.com, maciej.rutecki@gmail.com, rjw@sisk.pl, sedat.dilek@gmail.com * Florian Mickler wrote: > In order to get rid of the ugly CONFIG_ACPI ifdef, we move > the function acpi_get_override_irq into acpi.c and add a new > helper function ioapic_get_irq to io_apic.c. > > Signed-off-by: Florian Mickler > Cc: Len Brown > Cc: "Eric W. Biederman" > Cc: kurup_avinash@yahoo.com > Cc: maciej.rutecki@gmail.com > Cc: rjw@sisk.pl > Cc: sedat.dilek@gmail.com > LKML-Reference: <1301558489-4198-1-git-send-email-florian@mickler.org> > --- > > Hi Ingo, > > Instead of exporting find_irq_entry, irq_trigger and irq_polarity, I added a > new helper function 'ioapic_get_irq(..)' and exported that. > > Also I did it as a seperate commit, since it is more of a cleanup and the other > commit is already tested... hope this is ok. Yeah, looks good in principle. Mind porting to the latest x86 devel tree and resend the patch? I tried to apply your patch but there's a conflict. You can find the tree at: http://people.redhat.com/mingo/tip.git/README Thanks, Ingo