From mboxrd@z Thu Jan  1 00:00:00 1970
From: cbouatmailru@gmail.com (Anton Vorontsov)
Date: Tue, 12 Apr 2011 18:37:14 +0400
Subject: [RFC PATCH 1/5] gemini: convert to basic-mmio-gpio
In-Reply-To: <1302522502-24381-2-git-send-email-jamie@jamieiles.com>
References: <1302522502-24381-1-git-send-email-jamie@jamieiles.com>
	<1302522502-24381-2-git-send-email-jamie@jamieiles.com>
Message-ID: <20110412143714.GA8931@oksana.dev.rtsoft.ru>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Apr 11, 2011 at 12:48:18PM +0100, Jamie Iles wrote:
> The basic-mmio-gpio driver is capable of supporting this controller so
> convert the platform to use it for basic GPIO support.
> 
> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
[...]
> +#define GPIO_RES(__name, __addr) \
> +	{ \
> +		.start = (__addr), \
> +		.end = (__addr) + 0x3, \
> +		.flags = IORESOURCE_MEM, \
> +		.name = #__name, \
> +	}

Btw, how about moving this (repetitive) macro into basic_mmio_gpio.h?

Assuming, that there could be IRQ resources later, making
something like BGPIO_MEM_RES(name, addr, sz)?

Or, even better, some generic shorthand macro in linux/ioport.h?

#define IORES(__type, __name, __addr, __size)	\
	{					\
		.start = (__addr), 		\
		.end = (__addr) + (__size),	\
		.flags = IORESOURCE_##__type, 	\
		.name = #__name, 		\
	}

Would translate to

IORES(MEM, set, GEMINI_GPIO_BASE(i) + GPIO_DATA_SET), 3),
vs.
GPIO_RES(set, GEMINI_GPIO_BASE(i) + GPIO_DATA_SET),

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com