Re: [PATCH 4/5] gma500: Add a gtt allocator

[Thierry Reding <thierry.reding@avionic-design.de>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

* Alan Cox wrote:
> At the moment we don't do any page backing for the GTT so only the stolen
> area pages will actually work. That is fine for our initial framebuffer and
> a bit of testing but will need resolution (including alternate mmap methods
> and the like for s/g areas) eventually.
> 
> Rather than use some of the overcomplex stuff in the DRM we use the existing
> Linux resource allocators to hand out framebuffers and the like. This also has
> the nice result that /proc/iomem shows the allocations.
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/staging/gma500/psb_drv.h |   16 +++-
>  drivers/staging/gma500/psb_fb.c  |   32 +++++---
>  drivers/staging/gma500/psb_fb.h  |   13 +--
>  drivers/staging/gma500/psb_gtt.c |  155 ++++++++++++++++++++++++++++++++++++++
>  drivers/staging/gma500/psb_gtt.h |   30 ++++++-
>  5 files changed, 217 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/staging/gma500/psb_drv.h b/drivers/staging/gma500/psb_drv.h
> index c3609e0..7a0506a 100644
> --- a/drivers/staging/gma500/psb_drv.h
> +++ b/drivers/staging/gma500/psb_drv.h
> @@ -21,6 +21,7 @@
>  #define _PSB_DRV_H_
>  
>  #include <linux/version.h>
> +#include <linux/kref.h>
>  
>  #include <drm/drmP.h>
>  #include "drm_global.h"
> @@ -228,6 +229,7 @@ struct psb_intel_opregion {
>  	int enabled;
>  };
>  
> +

Gratuitous newline?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]