From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Keir Fraser <keir@xen.org>
Cc: xen-devel@lists.xensource.com,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian.Campbell@citrix.com, Tim.Deegan@citrix.com
Subject: Re: [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic
Date: Wed, 13 Apr 2011 09:32:10 -0400 [thread overview]
Message-ID: <20110413133210.GB15870@dumpdata.com> (raw)
In-Reply-To: <C9CB2168.2C9D6%keir@xen.org>
On Wed, Apr 13, 2011 at 09:46:15AM +0100, Keir Fraser wrote:
> On 12/04/2011 18:21, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
>
> > On Tue, Apr 12, 2011 at 02:06:05PM +0100, Keir Fraser wrote:
> >> On 12/04/2011 13:53, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
> >>
> >>>> How cunning.
> >>>>
> >>>> Why wouldn't you just allocate exactly the right size of array in
> >>>> XENMEM_set_memory_map?
> >>>
> >>> I was thinking about it, but the mm.c code did not have the
> >>> xen/xmalloc.h header, nor any references to xmalloc_array.
> >>>
> >>> Is it OK to make an xmalloc_array during a hypercall?
> >>
> >> Yes. I think the toolstack should be able to clean up on the newly-possible
> >> ENOMEM return from this hypercall.
> >
> > Hm, not sure what I am hitting, but I can't seem to be able to copy over the
> > contents to the newly allocated array from the guest (this works
> > fine with the previous version of the patch). This is what I get
>
> Your patch is not really quite right. I've attached a modified version for
> you to try.
Excellent, and it works quite nicely. Thank you.
next prev parent reply other threads:[~2011-04-13 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 21:35 [PATCH 0 of 4] Patches for PCI passthrough with modified E820 (v2) Konrad Rzeszutek Wilk
2011-04-11 21:35 ` [PATCH 1 of 4] tools: Add xc_domain_set_memory_map and xc_get_machine_memory_map calls (x86, amd64 only) Konrad Rzeszutek Wilk
2011-04-11 21:35 ` [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic Konrad Rzeszutek Wilk
2011-04-12 12:32 ` Keir Fraser
2011-04-12 12:53 ` Konrad Rzeszutek Wilk
2011-04-12 13:06 ` Keir Fraser
2011-04-12 17:21 ` Konrad Rzeszutek Wilk
2011-04-13 7:34 ` Jan Beulich
2011-04-13 13:31 ` Konrad Rzeszutek Wilk
2011-04-13 8:46 ` Keir Fraser
2011-04-13 13:32 ` Konrad Rzeszutek Wilk [this message]
2011-04-11 21:35 ` [PATCH 3 of 4] libxl: Add support for passing in the machine's E820 for PCI passthrough in libxl_device_pci_parse_bdf Konrad Rzeszutek Wilk
2011-04-12 12:19 ` Ian Campbell
2011-04-12 17:53 ` Konrad Rzeszutek Wilk
2011-04-12 18:44 ` Ian Campbell
2011-04-12 19:00 ` Konrad Rzeszutek Wilk
2011-04-12 19:29 ` Ian Campbell
2011-04-11 21:35 ` [PATCH 4 of 4] libxl: Convert E820_UNUSABLE and E820_RAM to E820_UNUSABLE as appropriate Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2011-04-12 20:31 [PATCH 0 of 4] Patches for PCI passthrough with modified E820 (v3) Konrad Rzeszutek Wilk
2011-04-12 20:31 ` [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413133210.GB15870@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Tim.Deegan@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.