From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup) Date: Wed, 13 Apr 2011 15:20:21 +0200 Message-ID: <201104131520.23648.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: > On 13/04/2011 11:35, "Christoph Egger" wrote: > > Cleanup for ASID emulation: > > - Use C99 integer types for asid numbers > > > > - asid.c: consistently use 'v' instead of 'curr' > > On what planet is that an improvement?? > > We use 'curr' as a convenient idiom to represent cached current. Whereas > 'v' is supposed to represent an arbitrary vcpu. Oh, that's the difference. I thought 'curr' is just another random name for an arbitrary vcpu. I will resend the patch w/o that hunk. > > I know it costs three extra characters per use, but it does make code > easier to understand. > > -- Keir > > > - Introduce svm_invlpga() used in ASID emulation patch > > > > Signed-off-by: Christoph Egger > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632