From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet()
Date: Wed, 13 Apr 2011 20:11:29 +0200 [thread overview]
Message-ID: <20110413181129.GA31081@volta.aurel32.net> (raw)
In-Reply-To: <BANLkTingaNF5-YtQUDu_xpft9Udk9Uowrw@mail.gmail.com>
On Tue, Apr 12, 2011 at 11:41:49PM +0100, Peter Maydell wrote:
> On 12 April 2011 22:59, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > I haven't look at the documentation, but for the neighbouring code it looks
> > clear that floatx80_eq() should be used instead of floatx80_eq_quiet().
>
> Actually I think it's irrelevant -- PerformComparisonOperation()
> is called only once, and the code before it carefully checks for
> any NaNs and takes a different code path in that case (jumping
> to the 'unordered' label). So it doesn't matter which function
> we use here. I don't particularly object if you think using the
> non _quiet one is aesthetically tidier. (The nwfpe code is all
> hovering on the edge of total obsolescence anyhow; I certainly
> don't have any test cases for it.)
>
Ok, I will simply drop it then.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2011-04-13 18:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 21:59 [Qemu-devel] [PATCH 00/19] softfloat and FPU fixes/improvements Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 01/19] softfloat: use GCC builtins to count the leading zeros Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 02/19] cpu-all.h: define CPU_LDoubleU Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 03/19] target-i386: use CPU_LDoubleU instead of a private union Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 04/19] target-i386: use float unions from cpu-all.h Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 05/19] target-i386: add floatx_{add, mul, sub} and use them Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 06/19] softfloat: add float*_unordered_{, quiet}() functions Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 07/19] softfloat-native: add float*_unordered_quiet() functions Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function Aurelien Jarno
2011-04-13 14:52 ` Peter Maydell
2011-04-13 15:38 ` Richard Henderson
2011-04-13 15:42 ` Peter Maydell
2011-04-13 15:53 ` Richard Henderson
2011-04-13 18:18 ` Aurelien Jarno
2011-04-14 9:14 ` Peter Maydell
2011-04-14 15:14 ` Richard Henderson
2011-04-14 15:39 ` Peter Maydell
2011-04-14 16:27 ` Richard Henderson
2011-04-14 16:48 ` Peter Maydell
2011-04-14 17:01 ` Richard Henderson
2011-04-12 21:59 ` [Qemu-devel] [PATCH 09/19] target-mips: use new float*_unordered*() functions Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 10/19] target-i386: fix CMPUNORDPS/D and CMPORDPS/D instructions Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 11/19] softfloat: rename float*_eq() into float*_eq_quiet() Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 12/19] softfloat: rename float*_eq_signaling() into float*_eq() Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 13/19] softfloat: move float*_eq and float*_eq_quiet Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 14/19] softfloat: improve description of comparison functions Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet() Aurelien Jarno
2011-04-12 22:41 ` Peter Maydell
2011-04-13 18:11 ` Aurelien Jarno [this message]
2011-04-12 21:59 ` [Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_eq_quiet() Aurelien Jarno
2011-04-13 15:15 ` Peter Maydell
2011-04-12 21:59 ` [Qemu-devel] [PATCH 17/19] target-ppc: fix SPE comparison functions Aurelien Jarno
2011-04-13 2:40 ` Nathan Froyd
2011-04-13 18:11 ` Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 18/19] target-mips: simplify FP comparisons Aurelien Jarno
2011-04-12 21:59 ` [Qemu-devel] [PATCH 19/19] target-mips: don't hardcode softfloat exception bits Aurelien Jarno
2011-04-13 15:45 ` [Qemu-devel] [PATCH 00/19] softfloat and FPU fixes/improvements Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413181129.GA31081@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.