From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-pm@lists.linux-foundation.org
Subject: Re: freezer: should barriers be smp ?
Date: Wed, 13 Apr 2011 22:58:17 +0200 [thread overview]
Message-ID: <201104132258.17705.rjw@sisk.pl> (raw)
In-Reply-To: <BANLkTi=F-C-vwX4PGGfbkdTBw3OWL-twfg@mail.gmail.com>
On Wednesday, April 13, 2011, Mike Frysinger wrote:
> when we suspend/resume Blackfin SMP systems, we notice that the
> freezer code runs on multiple cores. this is of course what you want
> -- freeze processes in parallel. however, the code only uses non-smp
> based barriers which causes us problems ... our cores need software
> support to keep caches in sync, so our smp barriers do just that. but
> the non-smp barriers do not, and so the frozen/thawed processes
> randomly get stuck in the wrong task state.
>
> thinking about it, shouldnt the freezer code be using smp barriers ?
Yes, it should, but rmb() and wmb() are supposed to be SMP barriers.
Or do you mean something different?
Rafael
next prev parent reply other threads:[~2011-04-13 20:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 6:14 freezer: should barriers be smp ? Mike Frysinger
2011-04-13 20:58 ` Rafael J. Wysocki
2011-04-13 20:58 ` Rafael J. Wysocki [this message]
2011-04-13 21:02 ` Mike Frysinger
2011-04-13 21:05 ` Pavel Machek
2011-04-13 21:05 ` Pavel Machek
2011-04-13 21:11 ` [uclinux-dist-devel] " Mike Frysinger
2011-04-13 21:11 ` Mike Frysinger
2011-04-13 21:53 ` Rafael J. Wysocki
2011-04-13 22:11 ` Alan Stern
2011-04-13 22:11 ` [linux-pm] " Alan Stern
2011-04-13 22:34 ` [linux-pm] [uclinux-dist-devel] freezer: should barriers be smp? Rafael J. Wysocki
2011-04-14 14:55 ` Alan Stern
2011-04-14 14:55 ` [linux-pm] " Alan Stern
2011-04-14 22:34 ` Rafael J. Wysocki
2011-04-15 14:32 ` Alan Stern
2011-04-15 14:32 ` Alan Stern
2011-04-14 22:34 ` Rafael J. Wysocki
2011-04-13 22:34 ` Rafael J. Wysocki
2011-04-13 22:22 ` [uclinux-dist-devel] freezer: should barriers be smp ? Mike Frysinger
2011-04-13 22:22 ` Mike Frysinger
2011-04-13 22:49 ` Rafael J. Wysocki
2011-04-13 22:53 ` Rafael J. Wysocki
2011-04-13 22:53 ` Rafael J. Wysocki
2011-04-13 22:57 ` Mike Frysinger
2011-04-13 22:57 ` Mike Frysinger
2011-04-13 23:12 ` Rafael J. Wysocki
2011-04-13 23:12 ` Rafael J. Wysocki
2011-04-14 15:13 ` [linux-pm] " Alan Stern
2011-04-14 22:40 ` Rafael J. Wysocki
2011-04-14 22:40 ` Rafael J. Wysocki
2011-04-14 15:13 ` Alan Stern
2011-04-13 22:49 ` [uclinux-dist-devel] " Rafael J. Wysocki
2011-04-13 21:53 ` Rafael J. Wysocki
2011-04-13 22:04 ` Alan Stern
2011-04-13 22:04 ` [linux-pm] " Alan Stern
2011-04-15 16:29 ` Pavel Machek
2011-04-15 16:33 ` Mike Frysinger
2011-04-15 16:33 ` [uclinux-dist-devel] [linux-pm] " Mike Frysinger
2011-04-15 16:57 ` [uclinux-dist-devel] " Pavel Machek
2011-04-15 16:57 ` [uclinux-dist-devel] [linux-pm] " Pavel Machek
2011-04-15 23:11 ` Rafael J. Wysocki
2011-04-15 23:24 ` Mike Frysinger
2011-04-15 23:30 ` [uclinux-dist-devel] " Rafael J. Wysocki
2011-04-15 23:30 ` [uclinux-dist-devel] [linux-pm] " Rafael J. Wysocki
2011-04-15 23:24 ` [uclinux-dist-devel] " Mike Frysinger
2011-04-15 23:11 ` Rafael J. Wysocki
2011-04-15 16:29 ` Pavel Machek
2011-04-13 21:02 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 6:14 Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104132258.17705.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.