From: Ralf Baechle <ralf@linux-mips.org>
To: Greg KH <gregkh@suse.de>
Cc: linux-usb@vger.kernel.org,
Manuel Lauss <manuel.lauss@googlemail.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] USB: OHCI: Fix build warning on Alchemy
Date: Thu, 14 Apr 2011 02:31:24 +0200 [thread overview]
Message-ID: <20110414003124.GA9660@linux-mips.org> (raw)
In-Reply-To: <20110413234317.GB17342@suse.de>
On Wed, Apr 13, 2011 at 04:43:17PM -0700, Greg KH wrote:
> On Thu, Apr 14, 2011 at 01:23:08AM +0200, Ralf Baechle wrote:
> > CC drivers/usb/host/ohci-hcd.o
> > In file included from drivers/usb/host/ohci-hcd.c:1028:0:
> > drivers/usb/host/ohci-au1xxx.c:36:7: warning: "__BIG_ENDIAN" is not defined [-Wundef]
> >
> > Fix the warning and some other build bullet proofing; let's not rely on
> > other needed header files getting dragged in magically.
>
> Ick, I just applied the second part of this patch to my "for-linus"
> tree as a patch from someone else. Are the #include changes really
> needed right now?
No, the include stuff was more for paranoia.
However the warning fixed by the 2nd part of the patch exists back to
at least 2.6.27.
Ralf
next prev parent reply other threads:[~2011-04-14 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 23:23 [PATCH] USB: OHCI: Fix build warning on Alchemy Ralf Baechle
2011-04-13 23:43 ` Greg KH
2011-04-14 0:31 ` Ralf Baechle [this message]
2011-04-14 2:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414003124.GA9660@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=gregkh@suse.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.