From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, openezx-devel@lists.openezx.org,
"John W . Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Guiming Zhuo <gmzhuo@gmail.com>
Subject: Re: [PATCH v3] rfkill: Regulator consumer driver for rfkill
Date: Thu, 14 Apr 2011 06:06:26 -0700 [thread overview]
Message-ID: <20110414130626.GA7890@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110414123912.71e4bd52.ospite@studenti.unina.it>
On Thu, Apr 14, 2011 at 12:39:12PM +0200, Antonio Ospite wrote:
> Johannes Berg <johannes@sipsolutions.net> wrote:
> > Should remove do platform_set_drvdata(pdev, NULL)?
> AFAICS this is not strictly necessary because we never check for NULL
> here and we are setting drvdata again in _probe() each time the module
> is loaded anyways. If it is considered a good practice for symmetry
> reasons then I'll add it, no problem. Does anyone has comments on that?
We went round this loop with I2C - anything peering at driver data that
it didn't originally set is buggy anyway so no need to reset to zero.
If there was a need the platform bus or driver core should do it since
all devices would need it.
next prev parent reply other threads:[~2011-04-14 13:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 9:21 [PATCH] rfkill: Regulator consumer driver for rfkill Antonio Ospite
2011-04-06 9:29 ` Johannes Berg
2011-04-06 14:06 ` Antonio Ospite
2011-04-06 14:09 ` Johannes Berg
2011-04-06 14:24 ` Antonio Ospite
2011-04-06 14:50 ` Joey Lee
2011-04-08 10:59 ` [PATCH v2] " Antonio Ospite
2011-04-12 11:41 ` Johannes Berg
2011-04-12 11:44 ` Johannes Berg
2011-04-12 15:15 ` Mark Brown
2011-04-12 15:23 ` Johannes Berg
2011-04-13 16:53 ` Mark Brown
2011-04-13 8:44 ` Antonio Ospite
2011-04-13 9:19 ` Johannes Berg
2011-04-13 19:40 ` [PATCH v3] " Antonio Ospite
2011-04-13 19:53 ` Johannes Berg
2011-04-14 10:39 ` Antonio Ospite
2011-04-14 13:06 ` Mark Brown [this message]
2011-04-15 10:24 ` Antonio Ospite
2011-04-13 8:53 ` [PATCH v2] " Antonio Ospite
2011-04-06 14:11 ` [PATCH] " Mark Brown
2011-04-06 14:21 ` Johannes Berg
2011-04-06 18:12 ` Paul Bolle
2011-04-06 18:38 ` John W. Linville
2011-04-06 20:10 ` Paul Bolle
2011-04-06 20:15 ` Johannes Berg
2011-04-06 20:17 ` Johannes Berg
2011-04-06 20:19 ` Johannes Berg
2011-04-06 18:46 ` Johannes Berg
2011-04-07 10:01 ` Bernd Petrovitsch
2011-04-07 10:09 ` Johannes Berg
2011-04-07 10:33 ` Bernd Petrovitsch
2011-04-07 10:42 ` depends on tristate logic (was: [PATCH] rfkill: Regulator consumer driver for rfkill) Johannes Berg
2011-04-06 14:29 ` [PATCH] rfkill: Regulator consumer driver for rfkill Antonio Ospite
2011-04-06 14:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414130626.GA7890@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gmzhuo@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marek.vasut@gmail.com \
--cc=openezx-devel@lists.openezx.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.