From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] at91: remove MTD_NAND_ATMEL_BUSWIDTH_16 option
Date: Thu, 14 Apr 2011 15:09:00 +0200 [thread overview]
Message-ID: <20110414130900.GC7290@game.jcrosoft.org> (raw)
In-Reply-To: <20110414125716.GI1611@n2100.arm.linux.org.uk>
> > +/*
> > + * board revision encoding
> > + * bit 0:
> > + * 0 => nand 8 bit
> > + * 1 => nand 16 bit
> > + */
> > +#define HAVE_NAND_16BIT (1 << 0)
> > +static int inline ek_have_nand_16bit(void)
> > +{
> > + return system_rev & HAVE_NAND_16BIT;
> > +}
>
> Do we really need six identical bits of code checking bit 0 of the system
> revision, which are different from an already established usage?
>
> Please consolidate this down to a single implementation.
I want to do it but the system_rev is 32bit only and I was not wishing to
impose it but if you incist I can try it
as example on 9g20 we have 1 or 2 mmc selection
on 9g45 we have lcd type
so I can try to reserve so upper bit for generic at91 feature and the rest
board specifc
Best Regards,
J.
next prev parent reply other threads:[~2011-04-14 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 16:29 [PATCH] at91: remove MTD_NAND_ATMEL_BUSWIDTH_16 option Jean-Christophe PLAGNIOL-VILLARD
2011-04-14 12:40 ` [PATCH v2] " Jean-Christophe PLAGNIOL-VILLARD
2011-04-14 12:57 ` Russell King - ARM Linux
2011-04-14 13:09 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-04-14 15:45 ` [PATCH v3] " Jean-Christophe PLAGNIOL-VILLARD
2011-04-17 19:39 ` Andrew Victor
2011-04-18 5:33 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414130900.GC7290@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.