From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] [PV Xen] Mouse stuck after save/restore of guest. Date: Thu, 14 Apr 2011 19:26:50 +0200 Message-ID: <20110414172649.GA7569@aepfle.de> References: <1302795907-321-1-git-send-email-imammedo@redhat.com> <20110414155915.GA23629@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20110414155915.GA23629@dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: Igor Mammedov , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Apr 14, Konrad Rzeszutek Wilk wrote: > On Thu, Apr 14, 2011 at 05:45:07PM +0200, Igor Mammedov wrote: > > Mouse stuck after restore of PV guest but buttons are > > in working condition. > > If driver has been configured for ABS coordinates at > > start it will get XENKBD_TYPE_POS events and then > > suddenly after restore it'll start getting > > XENKBD_TYPE_MOTION events, that will be dropped later > > and they won't get into user-space. > > > > Regression was introduced by hunk 5 and 6 of 5ea5254 > > in upstream. > > > > Driver on restore should ask xen for request-abs-pointer > > again if it's available. So restore parts that did it > > before 5ea5254. > > Olaf? This change is correct. Thanks for spotting, Igor. I did not test suspend/resume, migration etc. Sorry for that. During resume the guest has to renegotiate with the new qemu-dm process. Olaf