From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
werner <w.landgraf@ru.ru>,
gregkh@suse.de, tj@kernel.org, randy.dunlap@oracle.com,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: 2.6.39-rc3-git3 crashs after booting
Date: Thu, 14 Apr 2011 20:15:14 +0200 [thread overview]
Message-ID: <20110414181514.GA13977@elte.hu> (raw)
In-Reply-To: <1302803619.9800.4.camel@mulgrave.site>
* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> + /* temporary expedient, try to catch use of queue lock after
> + * free of sdev */
> + sdev->request_queue = NULL;
Couldnt help to notice this small ugliness while skimming the patch - please
use the customary (multi-line) comment style:
/*
* Comment .....
* ...... goes here.
*/
specified in Documentation/CodingStyle.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-14 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <web-504663160@zbackend1.aha.ru>
2011-04-14 17:40 ` 2.6.39-rc3-git3 crashs after booting Andrew Morton
2011-04-14 17:53 ` James Bottomley
2011-04-14 18:15 ` Ingo Molnar [this message]
2011-04-14 18:32 ` James Bottomley
2011-04-14 18:43 ` Ingo Molnar
2011-04-14 18:49 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414181514.GA13977@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=gregkh@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tj@kernel.org \
--cc=w.landgraf@ru.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.