From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] lib/hashtable: fix env var autocompletion
Date: Fri, 15 Apr 2011 03:57:29 -0400 [thread overview]
Message-ID: <201104150357.30604.vapier@gentoo.org> (raw)
In-Reply-To: <20110405121450.099cb324.kim.phillips@freescale.com>
On Tuesday, April 05, 2011 13:14:50 Kim Phillips wrote:
> commit c81c1222427f268d29ba999c82e2477c428e7bab "Fix hash
> table deletion to prevent lost entries" broke environment
> variable autocompletion by accidentally inverting the
> condition for 'used' in hmatch_r().
>
> 'used' is 0 if the hash table entry is not used, or -1 if deleted.
> This patch makes hmatch_r actually match on valid ('used') entries,
> instead of skipping them and failing to match anything.
blah, this started to annoy me quite a bit. and your patch wfm.
Tested-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/67e4ec72/attachment.pgp
next prev parent reply other threads:[~2011-04-15 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 1:17 [U-Boot] env: fix env var autocompletion Kim Phillips
2011-04-05 1:53 ` Mike Frysinger
2011-04-05 4:44 ` Peter Barada
2011-04-05 17:14 ` [U-Boot] [PATCH v2] lib/hashtable: " Kim Phillips
2011-04-15 7:57 ` Mike Frysinger [this message]
2011-04-27 22:55 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104150357.30604.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.