From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33])
	by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux))
	id 1QAe2u-000503-Dv
	for linux-mtd@lists.infradead.org; Fri, 15 Apr 2011 08:06:29 +0000
Date: Fri, 15 Apr 2011 10:06:21 +0200
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
To: Huang Shijie <b32955@freescale.com>
Subject: Re: [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28
Message-ID: <20110415080621.GL31990@pengutronix.de>
References: <1302854508-13652-1-git-send-email-b32955@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1302854508-13652-1-git-send-email-b32955@freescale.com>
Cc: s.hauer@pengutronix.de, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
	<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> +#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
Is it sensible to keep these when they are only used in a single .c
file?

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

From mboxrd@z Thu Jan  1 00:00:00 1970
From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=)
Date: Fri, 15 Apr 2011 10:06:21 +0200
Subject: [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28
In-Reply-To: <1302854508-13652-1-git-send-email-b32955@freescale.com>
References: <1302854508-13652-1-git-send-email-b32955@freescale.com>
Message-ID: <20110415080621.GL31990@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> +#define GPMI_NFC_DRIVER_NAME	"gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX23	"imx23-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX28	"imx28-gpmi-nfc"
> +#define GPMI_NFC_DRIVER_MX50	"imx50-gpmi-nfc"
Is it sensible to keep these when they are only used in a single .c
file?

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |