All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: dtor@mail.ru, linux-kernel@vger.kernel.org,
	Igor Mammedov <imammedo@redhat.com>,
	xen-devel@lists.xensource.com
Subject: Re: [Xen-devel] [PATCH] [PV Xen] Mouse stuck after save/restore of guest.
Date: Fri, 15 Apr 2011 11:37:38 +0200	[thread overview]
Message-ID: <20110415093737.GA15122@aepfle.de> (raw)
In-Reply-To: <20110414183804.GB1467@dumpdata.com>

On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:

> On Thu, Apr 14, 2011 at 07:26:50PM +0200, Olaf Hering wrote:
> > On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:
> > 
> > > On Thu, Apr 14, 2011 at 05:45:07PM +0200, Igor Mammedov wrote:
> > > >     Mouse stuck after restore of PV guest but buttons are
> > > >     in working condition.
> > > >     If driver has been configured for ABS coordinates at
> > > >     start it will get XENKBD_TYPE_POS events and then
> > > >     suddenly after restore it'll start getting
> > > >     XENKBD_TYPE_MOTION events, that will be dropped later
> > > >     and they won't get into user-space.
> > > > 
> > > >     Regression was introduced by hunk 5 and 6 of 5ea5254
> > > >     in upstream.
> > > > 
> > > >     Driver on restore should ask xen for request-abs-pointer
> > > >     again if it's available. So restore parts that did it 
> > > >     before 5ea5254.
> > > 
> > > Olaf?
> > 
> > This change is correct. Thanks for spotting, Igor.
> 
> Dmitry,
> 
> Was wondering if you are OK pushing this for 2.6.39-rc3 or whether you are OK
> with me doing. It fixes a regression introduced by the last hunk of 
> 5ea5254aa0ad269cfbd2875c973ef25ab5b5e9db

Looking through my backlog, I noticed that the patch went also to
stable@kernel.org and is now in various trees already.
So please forward this revert also to stable@suse.de

Olaf

  reply	other threads:[~2011-04-15  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14 15:45 [PATCH] [PV Xen] Mouse stuck after save/restore of guest Igor Mammedov
2011-04-14 15:59 ` Konrad Rzeszutek Wilk
2011-04-14 17:26   ` Olaf Hering
2011-04-14 18:38     ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-04-14 18:38       ` Konrad Rzeszutek Wilk
2011-04-15  9:37       ` Olaf Hering [this message]
2011-04-19 13:46         ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-04-19 14:55           ` Olaf Hering
2011-04-20  9:19             ` Igor Mammedov
2011-04-20  9:19               ` Igor Mammedov
2011-04-20 18:29         ` [Xen-devel] [PATCH] [PV Xen] Mouse stuck after save/restore of guest. - stable tree candidate Konrad Rzeszutek Wilk
2011-04-20 18:29           ` Konrad Rzeszutek Wilk
2011-04-27 16:31           ` [Xen-devel] " Olaf Hering
2011-04-27 23:32             ` [stable] " Greg KH
2011-04-27 23:32               ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110415093737.GA15122@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=dtor@mail.ru \
    --cc=imammedo@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.