From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
William Irwin <wli@holomorphy.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: hugetlb locking bug.
Date: Fri, 15 Apr 2011 17:26:00 -0400 [thread overview]
Message-ID: <20110415212600.GA3626@infradead.org> (raw)
In-Reply-To: <BANLkTimg+sVCAE17jLE9oz301oruVZbdbw@mail.gmail.com>
On Fri, Apr 15, 2011 at 02:19:01PM -0700, Linus Torvalds wrote:
> On Fri, Apr 15, 2011 at 2:09 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Fri, 2011-04-15 at 16:57 -0400, Christoph Hellwig wrote:
> >>
> >> Because it doesn't use iget or unlock_new_inode, but rather calls
> >> directly into new_inode(). ?It and other filesystems not using
> >> unlock_new_inode will need a local copy of that logic.
> >
> > Is there a sane reason they do their own magic, and thus need a copy of
> > the logic, instead of using the generic code that already has it?
>
> Hmm. That all seems to be just an oversight.
>
> Does this trivial one-liner work?
>
> (Warning: whitespace damage and TOTALLY UNTESTED)
It'll get rid of the lockdep spat in favour of a WARN_ON, given that
inodes from new_inode() never have I_NEW set.
next prev parent reply other threads:[~2011-04-15 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 20:16 hugetlb locking bug Dave Jones
2011-04-15 20:49 ` Linus Torvalds
2011-04-15 20:57 ` Christoph Hellwig
2011-04-15 21:09 ` Peter Zijlstra
2011-04-15 21:13 ` Christoph Hellwig
2011-04-15 21:23 ` Peter Zijlstra
2011-04-15 21:19 ` Linus Torvalds
2011-04-15 21:26 ` Christoph Hellwig [this message]
2011-04-15 21:27 ` Linus Torvalds
2011-12-14 11:59 ` Mimi Zohar
2011-04-15 21:07 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2011-08-22 15:34 Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415212600.GA3626@infradead.org \
--to=hch@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.