Re: [PATCH] kvm tools: Fix virtio console input problem

[Ingo Molnar <mingo@elte.hu>]

* Asias He <asias.hejun@gmail.com> wrote:

> On 04/16/2011 02:23 AM, Ingo Molnar wrote:
> > 
> > * Asias He <asias.hejun@gmail.com> wrote:
> > 
> >> Signed-off-by: Asias He <asias.hejun@gmail.com>
> >> ---
> >>  tools/kvm/term.c |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Mind explaining in the changelog what input problem this is about?
> 
> Sure. See attached patch.
> 
> -- 
> Best Regards,
> Asias He

> >From 6a123c8001c3c36ae5cc08d2980588491a6ef1ef Mon Sep 17 00:00:00 2001
> From: Asias He <asias.hejun@gmail.com>
> Date: Fri, 15 Apr 2011 22:55:04 +0800
> Subject: [PATCH] kvm tools: Fix virtio console input problem
> 
> term_getc only get one char at a time, so term_getc_iov should
> send one char back to guest.
> 
> Otherwise, you will get four input chars when you only type one like bewlow:
> 
> sid login: r^@^@^@o^@^@^@o^@^@^@t^@^@^@
> 
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
>  tools/kvm/term.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Ok, that changelog is much more informative, thanks!
Small typo: s/bewlow/below.

	Ingo