From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 18/21] drm/i915: Split out i915_gem_object_move_to_ring() from execbuffer Date: Sat, 16 Apr 2011 15:54:56 +0200 Message-ID: <20110416135455.GG3498@viiv.ffwll.ch> References: <1302945465-32115-1-git-send-email-chris@chris-wilson.co.uk> <1302945465-32115-19-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 0597F9E7A4 for ; Sat, 16 Apr 2011 06:55:01 -0700 (PDT) Received: by wyb28 with SMTP id 28so3701278wyb.36 for ; Sat, 16 Apr 2011 06:55:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302945465-32115-19-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 16, 2011 at 10:17:42AM +0100, Chris Wilson wrote: > As we can make use of the ability to insert semaphores to serialise > accessing buffers between ring elsewhere, separate out the function from > the execbuffer code and make it generic. Perhaps add a small note somewhere that move_to_ring now does the right thing when to == NULL (falling back to wait_rendering). I've hunted around a bit for that ... Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48