From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sat, 16 Apr 2011 15:45:00 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (jc42) Change I2C detection class Message-Id: <20110416154500.GA31343@ericsson.com> List-Id: References: <20110416141713.333d6e51@endymion.delvare> In-Reply-To: <20110416141713.333d6e51@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Sat, Apr 16, 2011 at 10:58:24AM -0400, Guenter Roeck wrote: > On Sat, Apr 16, 2011 at 08:17:13AM -0400, Jean Delvare wrote: > > While the JC42-compatible chips are temperature sensors, I2C_CLASS_SPD > > makes more sense because these chips always live on memory modules. > > > > Signed-off-by: Jean Delvare > > Cc: Guenter Roeck > > --- > > Guenter, what do you think? > > > I don't know. Seems odd to define a device based on its location instead of its functionality. > > What is the device class used for anyway ? I browsed through the code, but did not find it. > Never mind, I found it, and understand your reasoning now. Ok with me. Acked-by: Guenter Roeck _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors