From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687Ab1DRHZI (ORCPT ); Mon, 18 Apr 2011 03:25:08 -0400 Received: from cantor.suse.de ([195.135.220.2]:38774 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684Ab1DRHZD (ORCPT ); Mon, 18 Apr 2011 03:25:03 -0400 From: Oliver Neukum Organization: SUSE To: wanlong.gao@gmail.com Subject: Re: [PATCH 1/1] drivers/usb/image/mdc800.c: Remove "typdef enum". Date: Mon, 18 Apr 2011 09:26:17 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.39-rc2-12-desktop+; KDE/4.4.4; x86_64; ; ) Cc: Thiago Farina , linux-kernel@vger.kernel.org, "Greg Kroah-Hartman" , Arnd Bergmann , linux-usb@vger.kernel.org References: <014287655bd0c4327bbd946b9c823a0e4ec35f8e.1303079016.git.tfransosi@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104180926.17457.oneukum@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 18. April 2011, 02:54:16 schrieb Wanlong Gao: > > - > > /*************************************************************************** > > The USB Part of the driver > > ****************************************************************************/ > > -- > > 1.7.3.2.343.g7d43d > > > Why did you change it ? and why change so many lines ? > It had some thing wrong ? Exactly. This is a driver for legacy hardware. Could you leave it alone unless you fix a real, as in makes a difference to code generation, bug? Regards Oliver