From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Stodden <daniel.stodden@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH] xen/blkback: add xen-blkback support
Date: Mon, 18 Apr 2011 16:14:43 -0400 [thread overview]
Message-ID: <20110418201443.GC12562@dumpdata.com> (raw)
In-Reply-To: <1303151503.9965.65.camel@agari.van.xensource.com>
> > Hmm, let me remove those get/puts. They are actually not necessary as we
> > already hold a reference count when we opened the device.
>
> Ack. I never noticed these weren't exported.
>
> But bdev_get_queue is not an addref, just an accessor macro, as you're
> probably aware of.
Yes.
>
> But get/put is normally managed entirely in block/ and implied by the
> request and bdev interfaces.
And I found the reason for all of that. Way back in the past (2.6.18)
we would be checking the request_queue->flag to make sure it did not have
the QUEUE_FLAG_DEAD flag set. Over the years the block API started doing that
in the submit_bio path and .. well, we don't need this check anymore.
next prev parent reply other threads:[~2011-04-18 20:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 17:57 [RFC PATCH] Xen blkback for 2.6.40 Konrad Rzeszutek Wilk
2011-04-18 17:57 ` [PATCH] xen/blkback: add xen-blkback support Konrad Rzeszutek Wilk
2011-04-18 18:12 ` Konrad Rzeszutek Wilk
2011-04-18 18:31 ` Daniel Stodden
2011-04-18 20:14 ` Konrad Rzeszutek Wilk [this message]
2011-04-18 18:37 ` [RFC PATCH] Xen blkback for 2.6.40 Daniel Stodden
2011-04-18 20:12 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418201443.GC12562@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=daniel.stodden@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.