diff for duplicates of <20110419085514.GG2820@pulham.picochip.com> diff --git a/a/1.txt b/N1/1.txt index 2b73bd3..2a19856 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -50,3 +50,10 @@ On Tue, Apr 19, 2011 at 02:02:12PM +0530, Viresh Kumar wrote: > + spin_unlock_irqrestore(&dwc->lock, dwc->lflags); > + return 0; > + } + +>From the Synopsys datasheet it looks to me like pausing by clearing the +channel enable bit could cause data to be lost. I think you need to set +the CH_SUSP bit and wait for the FIFO_EMPTY flag to go high then disable +the channel. + +Jamie diff --git a/a/content_digest b/N1/content_digest index e96243b..09db4c1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,18 @@ "ref\0cover.1303194835.git.viresh.kumar@st.com\0" "ref\0a1168e413888e35badd9fab6b1626fcfe355dc9b.1303194836.git.viresh.kumar@st.com\0" - "From\0jamie@jamieiles.com (Jamie Iles)\0" - "Subject\0[PATCH V2 7/7] dmaengine/dw_dmac: implement pause and resume in dwc_control\0" + "From\0Jamie Iles <jamie@jamieiles.com>\0" + "Subject\0Re: [PATCH V2 7/7] dmaengine/dw_dmac: implement pause and resume in dwc_control\0" "Date\0Tue, 19 Apr 2011 09:55:15 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Viresh Kumar <viresh.kumar@st.com>\0" + "Cc\0linux-kernel@vger.kernel.org" + vinod.koul@intel.com + dan.j.williams@intel.com + linux-arm-kernel@lists.infradead.org + armando.visconti@st.com + shiraz.hashim@st.com + amit.goel@st.com + viresh.linux@gmail.com + " linus.walleij@linaro.org\0" "\00:1\0" "b\0" "On Tue, Apr 19, 2011 at 02:02:12PM +0530, Viresh Kumar wrote:\n" @@ -57,6 +66,13 @@ "> +\t\tdwc->paused = true;\n" "> +\t\tspin_unlock_irqrestore(&dwc->lock, dwc->lflags);\n" "> +\t\treturn 0;\n" - "> +\t}" + "> +\t}\n" + "\n" + ">From the Synopsys datasheet it looks to me like pausing by clearing the \n" + "channel enable bit could cause data to be lost. I think you need to set \n" + "the CH_SUSP bit and wait for the FIFO_EMPTY flag to go high then disable \n" + "the channel.\n" + "\n" + Jamie -d9f1e99c73048427ad1dac44dc5e5aa1fe64dd22cc1c4cd597869f8f77f57114 +d1594bb08f4009f9d6782e525345dd58dc2869cfd1f1e30e2e62d2f57294e133
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.