From: Jarkko Nikula <jhnikula@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 1/3] cbus: tahvo: Fix build breakage caused by deprecated initializer removal
Date: Tue, 19 Apr 2011 10:53:13 +0300 [thread overview]
Message-ID: <20110419105313.4c03f30d.jhnikula@gmail.com> (raw)
In-Reply-To: <20110419070724.GB477@atomide.com>
On Tue, 19 Apr 2011 00:07:24 -0700
Tony Lindgren <tony@atomide.com> wrote:
> * Jarkko Nikula <jhnikula@gmail.com> [110418 12:18]:
> > Use DEFINE_SPINLOCK() for static spinlock initialization as the commit
> > d04fa5a "locking: Remove deprecated lock initializers" removes the
> > deprecated SPIN_LOCK_UNLOCKED. Since tahvo_lock is not used elsewhere than
> > tahvo.c it can be removed from tahvo.h too.
>
> Thanks pushed all three. Looks like TAHVO_USB still fails
> to compile as the otg_set_transceiver may not be compiled.
>
True, it fails if CONFIG_OTG_UTILS is not set and it was selected
by musb in my config. I'll send a Kconfig fix for that.
--
Jarkko
prev parent reply other threads:[~2011-04-19 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 19:21 [PATCH 1/3] cbus: tahvo: Fix build breakage caused by deprecated initializer removal Jarkko Nikula
2011-04-18 19:21 ` [PATCH 2/3] cbus: retu: Fix build breakage caused by recent genirq commits Jarkko Nikula
2011-04-18 19:21 ` [PATCH 3/3] omap: Fix board-nokia770.c and board-n8x0 cbus build breakage Jarkko Nikula
2011-04-19 7:07 ` [PATCH 1/3] cbus: tahvo: Fix build breakage caused by deprecated initializer removal Tony Lindgren
2011-04-19 7:53 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419105313.4c03f30d.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.