All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net,
	Daniel Halperin <dhalperi@cs.washington.edu>
Subject: Re: [PATCH wireless-2.6] iwlwifi: fix frame injection for HT channels
Date: Tue, 19 Apr 2011 13:41:59 +0200	[thread overview]
Message-ID: <20110419114158.GA3445@redhat.com> (raw)
In-Reply-To: <1303141291-902-1-git-send-email-wey-yi.w.guy@intel.com>

On Mon, Apr 18, 2011 at 08:41:31AM -0700, Wey-Yi Guy wrote:
> From: Daniel Halperin <dhalperi@cs.washington.edu>
> 
> For some reason, sending QoS configuration causes transmission to stop
> after a single frame on HT channels when not associated. Removing the
> extra QoS configuration has no effect on station mode, and fixes
> injection mode.
> 
> Signed-off-by: Daniel Halperin <dhalperi@cs.washington.edu>
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> these patches are also available from wireless-2.6 branch on
>  git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git

This is basically revert of:

commit 35a6eb36520b938742d8680fd8d821df20982ced
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date:   Wed Nov 10 09:56:43 2010 -0800

    iwlwifi: resending QoS command when HT changes
    
    "mac80211: Fix WMM driver queue configuration"
    inadvertedly broke iwlwifi, because now mac80211
    configures the QoS settings before assoc, and
    therefore before HT. Thus, iwlwifi no longer told
    the device about the HT setting, which it needs
    to -- and thus throughput went down a lot. Fix
    this by resending the QoS command to the device
    not only when QoS/WMM settings change, but also
    when HT changes.

Does problem that 35a6eb36520b938742d8680fd8d821df20982ced fixed
gone now? How?

Stanislaw

  reply	other threads:[~2011-04-19 11:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 15:41 [PATCH wireless-2.6] iwlwifi: fix frame injection for HT channels Wey-Yi Guy
2011-04-19 11:41 ` Stanislaw Gruszka [this message]
2011-04-19 11:56   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110419114158.GA3445@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=dhalperi@cs.washington.edu \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.