From: Tony Lindgren <tony@atomide.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Mike Rapoport <mike@compulab.co.il>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x
Date: Tue, 19 Apr 2011 14:45:47 +0300 [thread overview]
Message-ID: <20110419114547.GC15620@atomide.com> (raw)
In-Reply-To: <BANLkTimHO1TUZsKHZ4akbGG9+C+AmVrP=A@mail.gmail.com>
* Mike Rapoport <mike.rapoport@gmail.com> [110419 14:32]:
> Hi Tony,
>
> On Mon, Apr 18, 2011 at 2:21 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Mike Rapoport <mike@compulab.co.il> [110417 01:21]:
> > Nice job Mike :)
>
> There's a _lot_ of very similar code in different board files. If
> you'd like to I can try to create something like
> common-board-devices.c and move most of that code there. It's not the
> real consolidation Linus wanted, but at least all the copy-pasted
> device initialization code would be removed.
Yes please do if you can, that helps a lot. Also most beagle
related boards could probably have a common board-beagle.c file.
Eventually the board configuration will come from device tree.
But until that's available, we can consolidate the code within
arch/arm/*omap*/ as the common platform init functions will still
be needed with configuration coming from DT.
Regards,
Tony
next prev parent reply other threads:[~2011-04-19 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 22:29 [PATCH 0/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x Mike Rapoport
2011-04-19 12:04 ` Mike Rapoport
2011-04-16 22:29 ` [PATCH 1/2] OMAP: gpmc-smsc911x: always set irq flags to IORESOURCE_IRQ_LOWLEVEL Mike Rapoport
2011-04-19 12:04 ` Mike Rapoport
2011-05-31 10:32 ` Tony Lindgren
2011-06-01 11:33 ` Igor Grinberg
2011-06-01 11:45 ` Tony Lindgren
2011-04-16 22:29 ` [PATCH 2/2] OMAP: convert boards that use SMSC911x to use gpmc-smsc911x Mike Rapoport
2011-04-19 12:04 ` Mike Rapoport
2011-04-18 11:21 ` [PATCH 0/2] " Tony Lindgren
2011-04-19 11:35 ` Mike Rapoport
2011-04-19 11:45 ` Tony Lindgren [this message]
2011-04-19 11:47 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419114547.GC15620@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.