From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: suspend/resume wakeup support
Date: Tue, 19 Apr 2011 21:49:25 +0000 [thread overview]
Message-ID: <20110419214925.GA32675@linux-sh.org> (raw)
In-Reply-To: <20110419104344.23764.93511.sendpatchset@t400s>
On Tue, Apr 19, 2011 at 07:43:44PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> This patch adds wakeup support to the sh-sci driver. As usual,
> device_init_wakeup() and enable_irq_wake()/disable_irq_wake()
> are used to determine if the port should be suspended/resumed
> as usual or if it should be enabled to act as a wakeup source.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
The serial core already does all of this, so I'm not sure I see the
point. If you've stumbled upon something the generic infrastructure
doesn't handle properly, then fix that up instead of reinventing it and
sidestepping the rest of the suspend/resume port ops.
next prev parent reply other threads:[~2011-04-19 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 10:43 [PATCH] serial: sh-sci: suspend/resume wakeup support Magnus Damm
2011-04-19 21:49 ` Paul Mundt [this message]
2011-04-21 13:03 ` Magnus Damm
2011-04-21 13:08 ` [PATCH] serial: sh-sci: suspend/resume wakeup support V2 Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419214925.GA32675@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.