From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [RFC PATCH v2] Consolidate SRAM support Date: Wed, 20 Apr 2011 06:06:41 +0200 Message-ID: <20110420040641.GF4204@game.jcrosoft.org> References: <20110415130607.GM1611@n2100.arm.linux.org.uk> <20110418085259.GA26044@n2100.arm.linux.org.uk> <20110419160135.GA4204@game.jcrosoft.org> <20110419161846.GB24972@n2100.arm.linux.org.uk> <20110419190557.GB4204@game.jcrosoft.org> <20110419232038.GC24972@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 30.mail-out.ovh.net ([213.186.62.213]:37013 "HELO 30.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750744Ab1DTEPh (ORCPT ); Wed, 20 Apr 2011 00:15:37 -0400 Content-Disposition: inline In-Reply-To: <20110419232038.GC24972@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: Sekhar Nori , Kevin Hilman , Tony Lindgren , Paul Mundt , Magnus Damm , davinci-linux-open-source@linux.davincidsp.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 00:20 Wed 20 Apr , Russell King - ARM Linux wrote: > On Tue, Apr 19, 2011 at 09:05:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 17:18 Tue 19 Apr , Russell King - ARM Linux wrote: > > > On Tue, Apr 19, 2011 at 06:01:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > Hi, > > > > > > > > I do post a patch to add the support to specify a virt and phys > > > > address to the generic allocator so the pv-pool.c is not needed > > > > we can just use the generic fucntion > > > > > > You've talked about this before in the thread, but the patch never appeared. > > I forget to re-send it sorry > > it's the mm tree > > One obvious issue here is that you're using 'unsigned long' for phys > addresses. With LPAE we could start seeing SRAM outside of the 4GB > PA range, and so would need this to be phys_addr_t. I'll update it any other issue? Best Regards, J. From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Wed, 20 Apr 2011 06:06:41 +0200 Subject: [RFC PATCH v2] Consolidate SRAM support In-Reply-To: <20110419232038.GC24972@n2100.arm.linux.org.uk> References: <20110415130607.GM1611@n2100.arm.linux.org.uk> <20110418085259.GA26044@n2100.arm.linux.org.uk> <20110419160135.GA4204@game.jcrosoft.org> <20110419161846.GB24972@n2100.arm.linux.org.uk> <20110419190557.GB4204@game.jcrosoft.org> <20110419232038.GC24972@n2100.arm.linux.org.uk> Message-ID: <20110420040641.GF4204@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 00:20 Wed 20 Apr , Russell King - ARM Linux wrote: > On Tue, Apr 19, 2011 at 09:05:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 17:18 Tue 19 Apr , Russell King - ARM Linux wrote: > > > On Tue, Apr 19, 2011 at 06:01:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > Hi, > > > > > > > > I do post a patch to add the support to specify a virt and phys > > > > address to the generic allocator so the pv-pool.c is not needed > > > > we can just use the generic fucntion > > > > > > You've talked about this before in the thread, but the patch never appeared. > > I forget to re-send it sorry > > it's the mm tree > > One obvious issue here is that you're using 'unsigned long' for phys > addresses. With LPAE we could start seeing SRAM outside of the 4GB > PA range, and so would need this to be phys_addr_t. I'll update it any other issue? Best Regards, J.