From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Ying Han <yinghan@google.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Nick Piggin <nickpiggin@yahoo.com.au>,
Minchan Kim <minchan.kim@gmail.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Pavel Emelyanov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Li Zefan <lizf@cn.fujitsu.com>, Mel Gorman <mel@csn.ul.ie>,
Christoph Lameter <cl@linux.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Zhu Yanhai <zhu.yanhai@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 0/3] pass the scan_control into shrinkers
Date: Wed, 20 Apr 2011 09:20:21 +0900 (JST) [thread overview]
Message-ID: <20110420092003.45EB.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1303235496-3060-1-git-send-email-yinghan@google.com>
> This patch changes the shrink_slab and shrinker APIs by consolidating existing
> parameters into scan_control struct. This simplifies any further attempts to
> pass extra info to the shrinker. Instead of modifying all the shrinker files
> each time, we just need to extend the scan_control struct.
>
Ugh. No, please no.
Current scan_control has a lot of vmscan internal information. Please
export only you need one, not all.
Otherwise, we can't change any vmscan code while any shrinker are using it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-20 0:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 17:51 [PATCH 0/3] pass the scan_control into shrinkers Ying Han
2011-04-19 17:51 ` [PATCH 1/3] move scan_control definition to header file Ying Han
2011-04-19 17:58 ` Ying Han
2011-04-19 20:30 ` Rik van Riel
2011-04-19 17:51 ` [PATCH 2/3] change the shrink_slab by passing scan_control Ying Han
2011-04-19 18:02 ` Ying Han
2011-04-19 20:30 ` Rik van Riel
2011-04-19 17:51 ` [PATCH 3/3] change shrinker API by passing scan_control struct Ying Han
2011-04-19 18:03 ` Ying Han
2011-04-19 20:30 ` Rik van Riel
2011-04-19 17:55 ` [PATCH 0/3] pass the scan_control into shrinkers Ying Han
2011-04-20 0:20 ` KOSAKI Motohiro [this message]
2011-04-20 0:51 ` Ying Han
2011-04-20 0:54 ` KOSAKI Motohiro
2011-04-20 1:03 ` Ying Han
2011-04-20 1:25 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420092003.45EB.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=minchan.kim@gmail.com \
--cc=nickpiggin@yahoo.com.au \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=riel@redhat.com \
--cc=tj@kernel.org \
--cc=xemul@openvz.org \
--cc=yinghan@google.com \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.