All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: bpm@sgi.com
Cc: aelder@sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: only SetPageUptodate if all buffers are uptodate
Date: Wed, 20 Apr 2011 11:36:14 -0400	[thread overview]
Message-ID: <20110420153614.GA11362@infradead.org> (raw)
In-Reply-To: <20110420145722.GB29759@sgi.com>

On Wed, Apr 20, 2011 at 09:57:22AM -0500, bpm@sgi.com wrote:
> Wish I did.  The test case that discovered this only applies to CXFS.  I
> would have liked to post a test case for XFS but decided that this has
> been on my TODO list for too long already.  Looks to me like it has to
> be related to the inode size, so you quit probing buffers after the
> first.  Maybe some discussion will ring some bells for somebody.

It would be really good to have one, but the actual patch looks good
enough that I'd consider putting it in.  I can assumes you ran
xfstests with various small blocksize options for both the test
and scratch device and it didn't show any regressions?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-04-20 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 11:40 [PATCH] xfs: only SetPageUptodate if all buffers are uptodate Ben Myers
2011-04-20 10:35 ` Christoph Hellwig
2011-04-20 14:57   ` bpm
2011-04-20 15:36     ` Christoph Hellwig [this message]
2011-06-23  5:08       ` Dave Chinner
2011-06-23  6:09         ` Dave Chinner
2011-06-23 10:35           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110420153614.GA11362@infradead.org \
    --to=hch@infradead.org \
    --cc=aelder@sgi.com \
    --cc=bpm@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.