From: Greg KH <gregkh@suse.de>
To: Roland Vossen <rvossen@broadcom.com>
Cc: devel@linuxdriverproject.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] staging: brcm80211: better feedback to user on ioctl errors
Date: Wed, 20 Apr 2011 09:08:35 -0700 [thread overview]
Message-ID: <20110420160835.GA25298@suse.de> (raw)
In-Reply-To: <1303288719-3036-1-git-send-email-rvossen@broadcom.com>
On Wed, Apr 20, 2011 at 10:38:39AM +0200, Roland Vossen wrote:
> Messages are now logged that provide the user with a clue on what went wrong.
Nice, you just provided a way for userspace to annoy the system log
readers by flooding it with useless information. :)
No, this kind of patch is not acceptable, sorry. Your userspace tools
should know better. Or at the very least, make this a debugging option
in the driver, not dev_err().
thanks,
greg k-h
prev parent reply other threads:[~2011-04-20 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 8:38 [PATCH] staging: brcm80211: better feedback to user on ioctl errors Roland Vossen
2011-04-20 16:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420160835.GA25298@suse.de \
--to=gregkh@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.