All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Nolan Leake <nolan@cumulusnetworks.com>
Cc: Jeff Dike <jdike@addtoit.com>, Nolan Leake <nolan@sigbus.net>,
	user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] um: Add a "ucast" ethernet transport.
Date: Thu, 21 Apr 2011 00:10:04 +0200	[thread overview]
Message-ID: <201104210010.04410.richard@nod.at> (raw)
In-Reply-To: <1303173986-21430-1-git-send-email-nolan@cumulusnetworks.com>

Am Dienstag 19 April 2011, 02:46:26 schrieb Nolan Leake:
> From: Nolan Leake <nolan@sigbus.net>
> 
> The "ucast" transport is similar to the mcast transport (and, in fact,
> shares most of its code), only it uses UDP unicast to move packets.
> 
> Obviously this is only useful for point-to-point connections between
> virtual ethernet devices.
> 
> Signed-off-by: Nolan Leake <nolan@cumulusnetworks.com>
> ---
>  Documentation/uml/UserModeLinux-HOWTO.txt |   10 ++
>  arch/um/drivers/Makefile                  |    4 +-
>  arch/um/drivers/mcast.h                   |   24 ----
>  arch/um/drivers/mcast_kern.c              |  120 ------------------
>  arch/um/drivers/mcast_user.c              |  165 -------------------------
>  arch/um/drivers/umcast.h                  |   27 ++++
>  arch/um/drivers/umcast_kern.c             |  188
> +++++++++++++++++++++++++++++ arch/um/drivers/umcast_user.c             | 
> 186 ++++++++++++++++++++++++++++ 8 files changed, 413 insertions(+), 311
> deletions(-)
>  delete mode 100644 arch/um/drivers/mcast.h
>  delete mode 100644 arch/um/drivers/mcast_kern.c
>  delete mode 100644 arch/um/drivers/mcast_user.c
>  create mode 100644 arch/um/drivers/umcast.h
>  create mode 100644 arch/um/drivers/umcast_kern.c
>  create mode 100644 arch/um/drivers/umcast_user.c
> 

One small nit-pick, please use "git format-patch --find-renames ...".
Otherwise tools like git-blame will produce bad results.

Thanks,
//richard

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel


      reply	other threads:[~2011-04-20 22:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 23:51 [uml-devel] [PATCH] um: Add a "ucast" ethernet transport Nolan Leake
2011-04-13 10:58 ` Richard Weinberger
2011-04-19  0:16   ` Nolan Leake
2011-04-19  0:46   ` Nolan Leake
2011-04-20 22:10     ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104210010.04410.richard@nod.at \
    --to=richard@nod.at \
    --cc=jdike@addtoit.com \
    --cc=nolan@cumulusnetworks.com \
    --cc=nolan@sigbus.net \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.