From: Grant Likely <grant.likely@secretlab.ca>
To: benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de
Subject: [RFC PATCH v2 4/4] powerpc: use irq_alloc_desc() to manage irq allocations
Date: Wed, 20 Apr 2011 22:04:09 -0600 [thread overview]
Message-ID: <20110421040408.30579.6215.stgit@ponder> (raw)
In-Reply-To: <20110421040036.30579.53752.stgit@ponder>
This patch drops the architecture specific code for managing irq
assignments and uses core code instead.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/kernel/irq.c | 49 ++++++++++++---------------------------------
1 files changed, 13 insertions(+), 36 deletions(-)
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 545e02f66..a36c2f0 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -974,53 +974,29 @@ unsigned int irq_linear_revmap(struct irq_host *host,
static unsigned int irq_alloc_virt(struct irq_host *host, unsigned int hint)
{
unsigned long flags;
- unsigned int i, j, found = NO_IRQ;
- int res;
+ unsigned int found;
- raw_spin_lock_irqsave(&irq_big_lock, flags);
-
- /* Use hint for 1 interrupt if any */
- if (hint >= NUM_ISA_INTERRUPTS &&
- hint < irq_virq_count && irq_map[hint].host == NULL) {
- found = hint;
- goto hint_found;
- }
-
- /* Look for a free virq in the allocatable (non-legacy) space */
- for (i = NUM_ISA_INTERRUPTS, j = 0; i < irq_virq_count; i++) {
- if (irq_map[i].host == NULL) {
- found = i;
- break;
- }
- }
+ /*
+ * Find an unused interrupt. First, attempt to allocate
+ * 'hint'. If that fails, then just allocate any free one.
+ */
+ found = irq_alloc_desc_at(hint, 0);
+ if (found == NO_IRQ)
+ found = irq_alloc_desc(0);
if (found == NO_IRQ) {
- raw_spin_unlock_irqrestore(&irq_big_lock, flags);
+ pr_debug("irq: -> allocating desc failed\n");
return NO_IRQ;
}
- hint_found:
+
+ raw_spin_lock_irqsave(&irq_big_lock, flags);
irq_map[found].hwirq = host->inval_irq;
smp_wmb();
irq_map[found].host = host;
raw_spin_unlock_irqrestore(&irq_big_lock, flags);
- res = irq_alloc_desc_at(found, 0);
- if (res != found) {
- pr_debug("irq: -> allocating desc failed\n");
- goto error_desc;
- }
-
irq_clear_status_flags(found, IRQ_NOREQUEST);
return found;
-
- error_desc:
- raw_spin_lock_irqsave(&irq_big_lock, flags);
- host = irq_map[found].host;
- irq_map[found].hwirq = host->inval_irq;
- smp_wmb();
- irq_map[found].host = NULL;
- raw_spin_unlock_irqrestore(&irq_big_lock, flags);
- return NO_IRQ;
}
/**
@@ -1041,13 +1017,14 @@ static void irq_free_virt(unsigned int virq)
return;
}
- irq_free_descs(virq, 1);
raw_spin_lock_irqsave(&irq_big_lock, flags);
host = irq_map[virq].host;
irq_map[virq].hwirq = host->inval_irq;
smp_wmb();
irq_map[virq].host = NULL;
raw_spin_unlock_irqrestore(&irq_big_lock, flags);
+
+ irq_free_descs(virq, 1);
}
int arch_early_irq_init(void)
prev parent reply other threads:[~2011-04-21 4:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 4:03 [RFC PATCH v2 0/4] Switch to core code for irq allocation Grant Likely
2011-04-21 4:03 ` [RFC PATCH v2 1/4] powerpc: stop exporting irq_map Grant Likely
2011-04-21 4:03 ` [RFC PATCH v2 2/4] powerpc: make irq_{alloc, free}_virt private and remove count argument Grant Likely
2011-04-21 4:04 ` [RFC PATCH v2 3/4] powerpc: move irq_alloc_descs_at() call into irq_alloc_virt() Grant Likely
2011-04-21 4:04 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421040408.30579.6215.stgit@ponder \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.