All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Chumbalkar, Nagananda" <Nagananda.Chumbalkar@hp.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Prarit Bhargava <prarit@redhat.com>,
	Tony Luck <tony.luck@intel.com>, Russ Anderson <rja@sgi.com>,
	LKML <linux-kernel@vger.kernel.org>,
	EDAC devel <linux-edac@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86, MCE: Do not taint when handling correctable errors
Date: Thu, 21 Apr 2011 12:06:39 +0200	[thread overview]
Message-ID: <20110421100639.GC10263@aftab> (raw)
In-Reply-To: <20110421095848.GA14889@elte.hu>

On Thu, Apr 21, 2011 at 05:58:48AM -0400, Ingo Molnar wrote:
> Ok, indeed. Also, in the future, if you take patches from others please also 
> credit them in the changelog. Something like this would have been good in the 
> current case:
> 
>   Also, this patch includes a change from Nagananda Chumbalkar as well, which 
>   drops tainting in the therma throttling code for a similar reason: crossing a
>   thermal threshold does not mean corruption.
> 
> Nagananda's Acked-by is there so there's at least partial credit - but we 
> generally try to aim for at least 100% credit where credit is due :-)

Absolutely, and in the light of recent events :) I'm still not sure how
to do that though in a straight-forward manner so that it is visible at
a first glance. Sure, adding freeform text to the commit message is one
way. Using a SOB chain might work too - even the Acked-by tag - but all
those have another main purpose and are being repurposed for annotating
the fact that a patch is the result of more than one author's thought
process.

IOW, in case I'm not missing anything, we don't really have a way to
denote a multiple authorship, correct? And we should...

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2011-04-21 10:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  8:45 [PATCH 1/2] x86, MCE: Do not taint when handling correctable errors Borislav Petkov
2011-04-15 17:05 ` Chumbalkar, Nagananda
2011-04-15 17:55   ` Luck, Tony
2011-04-21  9:35   ` Ingo Molnar
2011-04-21  9:51     ` Borislav Petkov
2011-04-21  9:58       ` Ingo Molnar
2011-04-21 10:06         ` Borislav Petkov [this message]
2011-04-21 10:20           ` Borislav Petkov
2011-04-21 11:21             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421100639.GC10263@aftab \
    --to=bp@amd64.org \
    --cc=Nagananda.Chumbalkar@hp.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=rja@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.