diff for duplicates of <20110421110841.GA612@suse.de> diff --git a/a/1.txt b/N1/1.txt index 14b1307..17e01cb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,14 +19,14 @@ On Thu, Apr 21, 2011 at 03:59:47PM +0900, Minchan Kim wrote: > > lock. The effect is noticable in page_test from aim9. > > > > AIM9 -> > 2.6.38-vanilla 2.6.38-checkptenone -> > creat-clo 446.10 ( 0.00%) 424.47 (-5.10%) -> > page_test 38.10 ( 0.00%) 42.04 ( 9.37%) -> > brk_test 52.45 ( 0.00%) 51.57 (-1.71%) -> > exec_test 382.00 ( 0.00%) 456.90 (16.39%) -> > fork_test 60.11 ( 0.00%) 67.79 (11.34%) +> > 2.6.38-vanilla 2.6.38-checkptenone +> > creat-clo 446.10 ( 0.00%) 424.47 (-5.10%) +> > page_test 38.10 ( 0.00%) 42.04 ( 9.37%) +> > brk_test 52.45 ( 0.00%) 51.57 (-1.71%) +> > exec_test 382.00 ( 0.00%) 456.90 (16.39%) +> > fork_test 60.11 ( 0.00%) 67.79 (11.34%) > > MMTests Statistics: duration -> > Total Elapsed Time (seconds) 611.90 612.22 +> > Total Elapsed Time (seconds) 611.90 612.22 > > > > (While this affects 2.6.38, it is a performance rather than a > > functional bug and normally outside the rules -stable. While the big @@ -37,22 +37,22 @@ On Thu, Apr 21, 2011 at 03:59:47PM +0900, Minchan Kim wrote: > > Reported-by: Raz Ben Yehuda <raziebe@gmail.com> > > Signed-off-by: Mel Gorman <mgorman@suse.de> > > -- -> > mm/memory.c | 2 +- -> > 1 file changed, 1 insertion(+), 1 deletion(-) +> > mm/memory.c | 2 +- +> > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 5823698..1659574 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -3322,7 +3322,7 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma, -> > * run pte_offset_map on the pmd, if an huge pmd could -> > * materialize from under us from a different thread. -> > */ -> > - if (unlikely(__pte_alloc(mm, vma, pmd, address))) -> > + if (unlikely(pmd_none(*pmd)) && __pte_alloc(mm, vma, pmd, address)) -> > return VM_FAULT_OOM; -> > /* if an huge pmd materialized from under us just retry later */ -> > if (unlikely(pmd_trans_huge(*pmd))) +> > * run pte_offset_map on the pmd, if an huge pmd could +> > * materialize from under us from a different thread. +> > */ +> > - if (unlikely(__pte_alloc(mm, vma, pmd, address))) +> > + if (unlikely(pmd_none(*pmd)) && __pte_alloc(mm, vma, pmd, address)) +> > return VM_FAULT_OOM; +> > /* if an huge pmd materialized from under us just retry later */ +> > if (unlikely(pmd_trans_huge(*pmd))) > > > > Reviewed-by: Minchan Kim <minchan.kim@gmail.com> @@ -76,3 +76,10 @@ problem particularly as it is encountered after failing a 2M allocation. -- Mel Gorman SUSE Labs + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 6e5879e..04d3fc4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -35,14 +35,14 @@ "> > lock. The effect is noticable in page_test from aim9.\n" "> >\n" "> > AIM9\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\2402.6.38-vanilla 2.6.38-checkptenone\n" - "> > creat-clo \302\240 \302\240 \302\240446.10 ( 0.00%) \302\240 424.47 (-5.10%)\n" - "> > page_test \302\240 \302\240 \302\240 38.10 ( 0.00%) \302\240 \302\24042.04 ( 9.37%)\n" - "> > brk_test \302\240 \302\240 \302\240 \302\24052.45 ( 0.00%) \302\240 \302\24051.57 (-1.71%)\n" - "> > exec_test \302\240 \302\240 \302\240382.00 ( 0.00%) \302\240 456.90 (16.39%)\n" - "> > fork_test \302\240 \302\240 \302\240 60.11 ( 0.00%) \302\240 \302\24067.79 (11.34%)\n" + "> > 2.6.38-vanilla 2.6.38-checkptenone\n" + "> > creat-clo 446.10 ( 0.00%) 424.47 (-5.10%)\n" + "> > page_test 38.10 ( 0.00%) 42.04 ( 9.37%)\n" + "> > brk_test 52.45 ( 0.00%) 51.57 (-1.71%)\n" + "> > exec_test 382.00 ( 0.00%) 456.90 (16.39%)\n" + "> > fork_test 60.11 ( 0.00%) 67.79 (11.34%)\n" "> > MMTests Statistics: duration\n" - "> > Total Elapsed Time (seconds) \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240611.90 \302\240 \302\240612.22\n" + "> > Total Elapsed Time (seconds) 611.90 612.22\n" "> >\n" "> > (While this affects 2.6.38, it is a performance rather than a\n" "> > functional bug and normally outside the rules -stable. While the big\n" @@ -53,22 +53,22 @@ "> > Reported-by: Raz Ben Yehuda <raziebe@gmail.com>\n" "> > Signed-off-by: Mel Gorman <mgorman@suse.de>\n" "> > --\n" - "> > \302\240mm/memory.c | \302\240 \302\2402 +-\n" - "> > \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> > mm/memory.c | 2 +-\n" + "> > 1 file changed, 1 insertion(+), 1 deletion(-)\n" "> >\n" "> > diff --git a/mm/memory.c b/mm/memory.c\n" "> > index 5823698..1659574 100644\n" "> > --- a/mm/memory.c\n" "> > +++ b/mm/memory.c\n" "> > @@ -3322,7 +3322,7 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,\n" - "> > \302\240 \302\240 \302\240 \302\240 * run pte_offset_map on the pmd, if an huge pmd could\n" - "> > \302\240 \302\240 \302\240 \302\240 * materialize from under us from a different thread.\n" - "> > \302\240 \302\240 \302\240 \302\240 */\n" - "> > - \302\240 \302\240 \302\240 if (unlikely(__pte_alloc(mm, vma, pmd, address)))\n" - "> > + \302\240 \302\240 \302\240 if (unlikely(pmd_none(*pmd)) && __pte_alloc(mm, vma, pmd, address))\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240return VM_FAULT_OOM;\n" - "> > \302\240 \302\240 \302\240 \302\240/* if an huge pmd materialized from under us just retry later */\n" - "> > \302\240 \302\240 \302\240 \302\240if (unlikely(pmd_trans_huge(*pmd)))\n" + "> > * run pte_offset_map on the pmd, if an huge pmd could\n" + "> > * materialize from under us from a different thread.\n" + "> > */\n" + "> > - if (unlikely(__pte_alloc(mm, vma, pmd, address)))\n" + "> > + if (unlikely(pmd_none(*pmd)) && __pte_alloc(mm, vma, pmd, address))\n" + "> > return VM_FAULT_OOM;\n" + "> > /* if an huge pmd materialized from under us just retry later */\n" + "> > if (unlikely(pmd_trans_huge(*pmd)))\n" "> >\n" "> \n" "> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>\n" @@ -91,6 +91,13 @@ "\n" "-- \n" "Mel Gorman\n" - SUSE Labs + "SUSE Labs\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -6bf9e129dd79af1169857c15b4e32a44983c3913e9933701e25b221fecf746e1 +259be6edca07a8da1c838ef214b5808806a61f3cc3de5406e63ed63639d6e449
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.